From: David Bremner <david@tethera.net>
To: Daiki Ueno <ueno@gnu.org>
Cc: 18513@debbugs.gnu.org
Subject: bug#18513: 24.3; message-mode sends unencrypted on error
Date: Mon, 29 Sep 2014 14:14:00 +0200 [thread overview]
Message-ID: <87k34mei9j.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <87zjdid6ny.fsf-ueno@gnu.org>
Daiki Ueno <ueno@gnu.org> writes:
> I've installed the following simple fix in the trunk. Does it work for you?
> === modified file 'lisp/gnus/mml.el'
> --- lisp/gnus/mml.el 2014-03-24 01:56:03 +0000
> +++ lisp/gnus/mml.el 2014-09-29 11:00:11 +0000
> @@ -257,7 +257,9 @@
> ((string= mode "encrypt")
> (setq tags (list "encrypt" method)))
> ((string= mode "signencrypt")
> - (setq tags (list "sign" method "encrypt" method))))
> + (setq tags (list "sign" method "encrypt" method)))
> + (t
> + (error "Unknown secure mode %s" mode)))
> (eval `(mml-insert-tag ,secure-mode
> ,@tags
> ,(if keyfile "keyfile")
It's definitely an improvement, and it fixes the scenario I reported. On
the other hand, if the use corrupts the #secure tag then essentially the
same behaviour results. Would it be possible to have a strict mode where
any unknown mml tag causes an error?
David
next prev parent reply other threads:[~2014-09-29 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 6:12 bug#18513: 24.3; message-mode sends unencrypted on error David Bremner
2014-09-29 11:09 ` Daiki Ueno
2014-09-29 12:14 ` David Bremner [this message]
2014-09-30 1:36 ` Daiki Ueno
2019-09-23 11:46 ` Lars Ingebrigtsen
2019-09-23 12:18 ` David Bremner
2019-09-23 13:53 ` Lars Ingebrigtsen
2019-09-24 10:49 ` Daniel Kahn Gillmor
2019-09-25 13:05 ` Lars Ingebrigtsen
2014-10-01 1:28 ` Glenn Morris
2014-10-01 2:32 ` Daiki Ueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k34mei9j.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=18513@debbugs.gnu.org \
--cc=ueno@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.