all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ivan Shmakov <ivan@siamics.net>
To: 18510@debbugs.gnu.org
Subject: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough
Date: Sat, 11 Oct 2014 13:30:30 +0000	[thread overview]
Message-ID: <87k3463f9l.fsf@violet.siamics.net> (raw)
In-Reply-To: <874mw3vg49.fsf@tromey.com>

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

 >> Your patch worked!  I applied it to my running Emacs and removed the
 >> advice and waited to see if the ERC mode line updated.

 > Thanks, installed, closing,

	Please consider the patch MIMEd.

	This should fix the issue introduced in 67c13dfc627d that now
	prevents erc-modified-channels-object from being updated when
	the buffer has already seen some activity /and/ then sees some
	more important (as per erc-track-faces-priority-list) activity
	in the same buffer.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 418 bytes --]

--- a/lisp/erc/erc-track.el
+++ b/lisp/erc/erc-track.el
@@ -860,7 +860,7 @@ Use `erc-make-mode-line-buffer-name' to create buttons."
 			faces (cdr faces)))
 		strings)))
 	   (newobject (erc-modified-channels-object strings)))
-      (unless (equal oldobject newobject)
+      (unless (equal-including-properties oldobject newobject)
 	(setq erc-modified-channels-object newobject)
 	(force-mode-line-update t)))))
 

  reply	other threads:[~2014-10-11 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 14:28 bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Tom Tromey
2014-09-19 17:25 ` Stefan Monnier
2014-09-19 18:37   ` Stefan Monnier
2014-09-24 13:20     ` Stefan Monnier
2014-09-24 16:37       ` Tom Tromey
2014-09-24 17:32         ` Stefan Monnier
2014-10-11 13:30           ` Ivan Shmakov [this message]
2014-10-15  1:16             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3463f9l.fsf@violet.siamics.net \
    --to=ivan@siamics.net \
    --cc=18510@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.