bug#19552: 25.0.50; void-function class-slot-initarg with new EIEIO changes

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> Debugger entered--Lisp error: (void-function class-slot-initarg)
>
> Indeed, this function doesn't exist any more: it was renamed to
> eieio--class-slot-initarg, since it's an internal function (EIEIO was
> horrible w.r.t namespace and w.r.t documenting what is internal and
> what isn't.  It's far from perfect now, mind you, but I've tried to
> make things a bit better in this respect)
>
> Can you try to (defalias 'class-slot-initarg 'eieio--class-slot-initarg)
> and see if that works around your problem?
>
>
>         Stefan

(Sorry for out-of-order messages, just authenticated.)

I tried the above, and loading helm now gives:

Debugger entered--Lisp error: (wrong-type-argument eieio--class-p helm-locate-source)
  signal(wrong-type-argument (eieio--class-p helm-locate-source))
  eieio--class-slot-initarg(helm-locate-source name)
  (setq slot (eieio--class-slot-initarg class s))
  (while (consp --cl-var--) (setq s (car --cl-var--)) (setq slot (eieio--class-slot-initarg class s)) (setq slot-val (slot-value object slot)) (if slot-val (progn (setq --cl-var-- (cons (cons s (if (eq t slot-val) nil slot-val)) --cl-var--)))) (setq --cl-var-- (cdr --cl-var--)))
  (let* ((--cl-var-- (object-slots object)) (s nil) (slot nil) (slot-val nil) (--cl-var-- nil)) (while (consp --cl-var--) (setq s (car --cl-var--)) (setq slot (eieio--class-slot-initarg class s)) (setq slot-val (slot-value object slot)) (if slot-val (progn (setq --cl-var-- (cons (cons s (if ... nil slot-val)) --cl-var--)))) (setq --cl-var-- (cdr --cl-var--))) (nreverse --cl-var--))
  helm--create-source([eieio-class-tag--helm-locate-source "Locate" nil helm-locate-set-command nil nil nil nil ELIDED helm-locate-init] helm-locate-source)
  helm-make-source("Locate" helm-locate-source :pattern-transformer helm-locate-pattern-transformer)
  (defvar helm-source-locate (helm-make-source "Locate" (quote helm-locate-source) :pattern-transformer (quote helm-locate-pattern-transformer)))
  require(helm-locate)