Is this use of nreverse a good practice?

Is this use of nreverse a good practice?

[Marcin Borkowski]

Hi there,

I'm writing a small function which should build a list and return it.
What I'm doing is more or less this:

(defun myfunc ()
  (let ((list-var))
    (while CONDITION
      (DO-SOMETHING)
      (push SOME-ELEMENT list-var))
    (nreverse list-var)))

A more concrete example:

(defun reverse-range (n)
  (let ((list-var))
    (while (> n 0)
      (push n list-var)
      (decf n))
    (nreverse list-var)))

(reverse-range 5)

⇒ (5 4 3 2 1)

Is this usage of `nreverse' correct?  I guess it is, since list-var is
only a temporary variable and destructing it doesn't bother me.
However, I'm never sure I'm doing things right when using
nconc/nreverse, so I though I'd better ask...

TIA,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

Re: Is this use of nreverse a good practice?

[Pascal J. Bourguignon]

Marcin Borkowski <mbork@wmi.amu.edu.pl> writes:

> Hi there,
>
> I'm writing a small function which should build a list and return it.
> What I'm doing is more or less this:
>
> (defun myfunc ()
>   (let ((list-var))
>     (while CONDITION
>       (DO-SOMETHING)
>       (push SOME-ELEMENT list-var))
>     (nreverse list-var)))
>
> A more concrete example:
>
> (defun reverse-range (n)
>   (let ((list-var))
>     (while (> n 0)
>       (push n list-var)
>       (decf n))
>     (nreverse list-var)))
>
> (reverse-range 5)
>
> ⇒ (5 4 3 2 1)
>
> Is this usage of `nreverse' correct?  I guess it is, since list-var is
> only a temporary variable and destructing it doesn't bother me.
> However, I'm never sure I'm doing things right when using
> nconc/nreverse, so I though I'd better ask...

Yes, this is THE use case for nreverse.

-- 
__Pascal Bourguignon__                 http://www.informatimago.com/
“The factory of the future will have only two employees, a man and a
dog. The man will be there to feed the dog. The dog will be there to
keep the man from touching the equipment.” -- Carl Bass CEO Autodesk