From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: bruce.connor.am@gmail.com
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: package.el dependencies
Date: Mon, 02 Feb 2015 16:19:24 +0100 [thread overview]
Message-ID: <87k3009w8z.fsf@gmail.com> (raw)
In-Reply-To: <CAAdUY-J4wKFxiFiKNwA8Qhi3wNqPUzPwY0ZyjNa_zqoFQ4xEbA@mail.gmail.com>
Artur Malabarba <bruce.connor.am@gmail.com> writes:
>>> We have now duplicates with package--get-deps:
>>>
>>> (package--get-deps 'jedi)
>>> =>(epc auto-complete python-environment epc auto-complete
>>> python-environment
>>> concurrent ctable concurrent ctable deferred deferred
>>> popup popup deferred deferred)
>>>
>>> As a workaround, you can use delete-dups, but this need to be
>>> implemented differently IMO.
>>
>> Maybe like this:
>>
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index 9a29d63..2157174 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -1428,9 +1428,8 @@ The file can either be a tar file or an Emacs Lisp file."
>> when (assq name package-alist)
>> collect name))
>> (indirect-deps (unless (eq only 'direct)
>> - (apply #'append
>> - direct-deps
>
> Yes, I made a mistake by adding the `direct-deps' here. I'll remove it.
>
>> - (mapcar #'package--get-deps direct-deps)))))
>> + (cl-loop for p in direct-deps
>> + append (package--get-deps p 'direct)))))
>> (cl-case only
>> (direct direct-deps)
>> (separate (list direct-deps indirect-deps))
>>
>> (package--get-deps 'jedi)
>> => (epc auto-complete python-environment concurrent ctable popup deferred)
>
> It may have solved this particular example, but if two direct
> dependencies share the same (indirect) dependency then this will still
> lead to duplicates. We could try writting an efficient way of avoiding
> this duplicates, but I'm fine with just using `delete-dups'.
Yes I think using delete-dups is ok for the extras duplicates in this
case, but see below to avoid most of the duplicates.
So it would be:
(cl-loop for p in direct-deps
append (package--get-deps p 'direct) into deps
finally return (delete-dups deps))
> And one more thing. Why did you use `(package--get-deps p 'direct)' in
> this snippet? Passing the `direct' argument will cause it to only
> return 2nd level dependencies at most (direct dependencies of the
> direct dependencies).
Don't think so, see below.
> I think it should be just `(package--get-deps p)', shouldn't it?
No, this avoid duplicates and it will in turn recurse in the direct
dependency of the dependency and so on, if you don't specify 'direct you
will have immediately duplicates.
> This way it'll keep searching untill the bottom of the dependency
> tree.
It will with the recursion and the 'direct flag.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2015-02-02 15:19 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 13:37 package.el dependencies Thierry Volpiatto
2015-01-23 13:46 ` Dmitry Gutov
2015-01-23 14:12 ` Ivan Shmakov
2015-01-23 20:40 ` Stefan Monnier
2015-01-23 21:02 ` Thierry Volpiatto
2015-01-24 0:50 ` Artur Malabarba
2015-01-24 4:55 ` Stefan Monnier
2015-01-25 6:51 ` Thierry Volpiatto
2015-01-26 7:17 ` Thierry Volpiatto
2015-01-26 9:19 ` Artur Malabarba
2015-01-26 9:54 ` Thierry Volpiatto
2015-01-26 12:46 ` Artur Malabarba
2015-01-26 14:52 ` Stefan Monnier
2015-01-27 6:10 ` Thierry Volpiatto
2015-01-27 11:52 ` Artur Malabarba
2015-01-25 9:18 ` Thierry Volpiatto
2015-01-25 14:54 ` Stefan Monnier
2015-01-25 15:48 ` Thierry Volpiatto
2015-01-25 17:10 ` Dmitry Gutov
2015-01-25 18:32 ` Stephen Leake
2015-01-25 18:21 ` Artur Malabarba
2015-01-26 4:48 ` Thierry Volpiatto
2015-01-26 12:35 ` Artur Malabarba
2015-01-26 12:53 ` Artur Malabarba
2015-01-26 15:22 ` Thierry Volpiatto
2015-01-26 15:44 ` Stefan Monnier
2015-01-27 6:08 ` Thierry Volpiatto
2015-01-26 16:34 ` Artur Malabarba
2015-01-28 7:30 ` Thierry Volpiatto
2015-01-28 8:55 ` Thierry Volpiatto
2015-01-28 12:42 ` Thierry Volpiatto
2015-01-28 13:17 ` Artur Malabarba
2015-01-28 14:32 ` Thierry Volpiatto
2015-01-28 13:40 ` Dmitry Gutov
2015-01-28 10:47 ` Artur Malabarba
2015-01-28 11:58 ` Thierry Volpiatto
2015-01-28 19:33 ` Stefan Monnier
2015-01-28 19:50 ` Ivan Shmakov
2015-01-28 20:12 ` Artur Malabarba
2015-01-28 22:20 ` Stefan Monnier
2015-01-29 5:31 ` Thierry Volpiatto
2015-01-29 7:22 ` Thierry Volpiatto
2015-01-30 5:38 ` Thierry Volpiatto
2015-01-30 16:43 ` Artur Malabarba
2015-01-30 17:13 ` Thierry Volpiatto
2015-01-31 6:01 ` Thierry Volpiatto
2015-01-31 10:58 ` Artur Malabarba
2015-01-31 20:26 ` Stefan Monnier
[not found] ` <874mr67gjb.fsf@gmail.com>
[not found] ` <jwvvbjmnun4.fsf-monnier+emacs@gnu.org>
[not found] ` <87oapervqv.fsf@gmail.com>
[not found] ` <jwvk302nnmd.fsf-monnier+emacs@gnu.org>
[not found] ` <877fw2kp1y.fsf@gmail.com>
[not found] ` <jwvioflbrlg.fsf-monnier+emacs@gnu.org>
[not found] ` <87d25tps2q.fsf@gmail.com>
[not found] ` <jwvy4oggva5.fsf-monnier+emacs@gnu.org>
2015-02-02 20:35 ` Thierry Volpiatto
2015-02-02 21:37 ` Artur Malabarba
2015-02-03 4:53 ` Thierry Volpiatto
2015-02-03 5:13 ` Stefan Monnier
2015-02-03 10:04 ` Artur Malabarba
2015-02-03 14:06 ` Artur Malabarba
2015-02-03 5:45 ` Thierry Volpiatto
2015-02-03 10:05 ` Artur Malabarba
2015-02-03 10:18 ` Thierry Volpiatto
2015-02-03 11:39 ` Artur Malabarba
2015-02-02 21:19 ` Thierry Volpiatto
2015-02-02 21:22 ` Dmitry Gutov
2015-02-03 11:39 ` Artur Malabarba
2015-02-03 11:44 ` Dmitry Gutov
2015-01-31 6:51 ` Thierry Volpiatto
2015-01-31 20:30 ` Stefan Monnier
2015-01-31 22:10 ` Thierry Volpiatto
2015-01-31 23:26 ` Artur Malabarba
2015-02-01 6:29 ` Thierry Volpiatto
2015-02-01 7:02 ` Thierry Volpiatto
2015-02-01 15:55 ` Thierry Volpiatto
2015-02-01 23:47 ` Artur Malabarba
2015-02-02 12:00 ` Artur Malabarba
2015-02-02 13:14 ` Thierry Volpiatto
2015-02-02 14:14 ` Thierry Volpiatto
2015-02-02 14:56 ` Artur Malabarba
2015-02-02 15:19 ` Thierry Volpiatto [this message]
2015-02-02 15:33 ` Thierry Volpiatto
2015-02-02 15:50 ` Artur Malabarba
2015-02-02 16:07 ` Thierry Volpiatto
2015-02-02 21:23 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3009w8z.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.