From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#20712: 25.0.50; save-place-mode doesn't work for new files Date: Wed, 17 Jun 2015 15:54:34 +0200 Message-ID: <87k2v24ezp.fsf@gnu.org> References: <87bngzqk7z.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1434549326 14929 80.91.229.3 (17 Jun 2015 13:55:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Jun 2015 13:55:26 +0000 (UTC) Cc: 20712@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 17 15:55:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z5DoA-0001rQ-Fn for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jun 2015 15:55:14 +0200 Original-Received: from localhost ([::1]:47058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Do9-0001Fv-CU for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jun 2015 09:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Do4-0001DL-83 for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 09:55:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Do0-0005gi-0E for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 09:55:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Dnz-0005g9-TH for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 09:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z5Dnz-0007sj-4V for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2015 09:55:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jun 2015 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20712-submit@debbugs.gnu.org id=B20712.143454928230257 (code B ref 20712); Wed, 17 Jun 2015 13:55:02 +0000 Original-Received: (at 20712) by debbugs.gnu.org; 17 Jun 2015 13:54:42 +0000 Original-Received: from localhost ([127.0.0.1]:57043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5Dnd-0007rx-C1 for submit@debbugs.gnu.org; Wed, 17 Jun 2015 09:54:41 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:47971) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5Dnb-0007rh-T8 for 20712@debbugs.gnu.org; Wed, 17 Jun 2015 09:54:40 -0400 Original-Received: from thinkpad-t440p (dhcp126.uni-koblenz.de [141.26.71.126]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 76DCD1A821E; Wed, 17 Jun 2015 15:54:34 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Wed, 17 Jun 2015 09:47:22 -0400") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104025 Archived-At: Stefan Monnier writes: >> Putting (save-place-mode) in ~/.emacs doesn't have the desired effects >> for new files, i.e., files which have no entry in `save-place-alist' / >> `save-place-file' yet. >> >> Recipe: >> 1. emacs -Q --eval '(save-place-mode)' test.txt >> 2. Add\nsome\ntext. >> 3. save and quit emacs >> 4. emacs -Q --eval '(save-place-mode)' test.txt >> >> Expected: point is on the dot in "text." >> Actual: point is at 0 > [...] >> introduced with the commit 9c3e1e4e5bc230c4b4fd6649b6afb5d4792592c2. > > Oh, indeed, I see the problem: despite the ":global t" argument, > define-minor-mode sets the var with `setq' rather than with > `setq-default', so the make-variable-buffer-local causes this code to > only set the var buffer-locally. > > I think define-minor-mode should use setq-default instead. > > Can you try the patch below (after which you need to re-compile > saveplace.el)? Yes, then it works again. What a relief! :-) Bye, Tassilo