From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 20712@debbugs.gnu.org
Subject: bug#20712: 25.0.50; save-place-mode doesn't work for new files
Date: Wed, 17 Jun 2015 15:54:34 +0200 [thread overview]
Message-ID: <87k2v24ezp.fsf@gnu.org> (raw)
In-Reply-To: <jwvsi9qeank.fsf-monnier+bug#20712@gnu.org> (Stefan Monnier's message of "Wed, 17 Jun 2015 09:47:22 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Putting (save-place-mode) in ~/.emacs doesn't have the desired effects
>> for new files, i.e., files which have no entry in `save-place-alist' /
>> `save-place-file' yet.
>>
>> Recipe:
>> 1. emacs -Q --eval '(save-place-mode)' test.txt
>> 2. Add\nsome\ntext.
>> 3. save and quit emacs
>> 4. emacs -Q --eval '(save-place-mode)' test.txt
>>
>> Expected: point is on the dot in "text."
>> Actual: point is at 0
> [...]
>> introduced with the commit 9c3e1e4e5bc230c4b4fd6649b6afb5d4792592c2.
>
> Oh, indeed, I see the problem: despite the ":global t" argument,
> define-minor-mode sets the var with `setq' rather than with
> `setq-default', so the make-variable-buffer-local causes this code to
> only set the var buffer-locally.
>
> I think define-minor-mode should use setq-default instead.
>
> Can you try the patch below (after which you need to re-compile
> saveplace.el)?
Yes, then it works again. What a relief! :-)
Bye,
Tassilo
next prev parent reply other threads:[~2015-06-17 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 19:53 bug#20712: 25.0.50; save-place-mode doesn't work for new files Tassilo Horn
[not found] ` <handler.20712.B.1433188411384.ack@debbugs.gnu.org>
2015-06-17 7:03 ` Tassilo Horn
2015-06-17 13:47 ` Stefan Monnier
2015-06-17 13:54 ` Tassilo Horn [this message]
2015-06-17 18:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2v24ezp.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=20712@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.