BUG in columns view since 0f93638ce (Jun 2 2015)

BUG in columns view since 0f93638ce (Jun 2 2015)

[Johan Sandblom]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Consider the attached orgmode file fragment, also included below. Prior 
to commit 0f93638ce sums were produced in the top row. After that 
commit, column view sums fail. Poor knowledge of git and elisp prevent 
me from finding the actual problem, but I did manage to find the first 
commit were it fails, and this hopefully helps

* sum
   :PROPERTIES:
   :COLUMNS:  %30ITEM %5A{+} %5B{+}
   :END:
** bla
*** blabla
     :PROPERTIES:
     :A:        1
     :END:
** bli
    :PROPERTIES:
    :A:        1
    :END:


-- 
Johan Sandblom, MD PhD
m +46735521477
What is wanted is not the will to believe, but the
will to find out, which is the exact opposite
--Bertrand Russell

[-- Attachment #2: test.org --]
[-- Type: text/plain, Size: 174 bytes --]

* sum
  :PROPERTIES:
  :COLUMNS:  %30ITEM %5A{+} %5B{+}
  :END:
** bla
*** blabla
    :PROPERTIES:
    :A:        1
    :END:
** bli
   :PROPERTIES:
   :A:        1
   :END:

Re: BUG in columns view since 0f93638ce (Jun 2 2015)

[Nicolas Goaziou]

Hello,

Johan Sandblom <js@ndblom.se> writes:

> Consider the attached orgmode file fragment, also included below.
> Prior to commit 0f93638ce sums were produced in the top row. After
> that commit, column view sums fail. Poor knowledge of git and elisp
> prevent me from finding the actual problem, but I did manage to find
> the first commit were it fails, and this hopefully helps
>
> * sum
>   :PROPERTIES:
>   :COLUMNS:  %30ITEM %5A{+} %5B{+}
>   :END:
> ** bla
> *** blabla
>     :PROPERTIES:
>     :A:        1
>     :END:
> ** bli
>    :PROPERTIES:
>    :A:        1
>    :END:

This is fixed. Thank you.


Regard,

-- 
Nicolas Goaziou

Re: BUG in columns view since 0f93638ce (Jun 2 2015)

[Johan Sandblom]

2015-08-11 19:13 skrev Nicolas Goaziou:
> Hello,
>
> Johan Sandblom <js@ndblom.se> writes:
>
>> Consider the attached orgmode file fragment, also included below.
>> Prior to commit 0f93638ce sums were produced in the top row. After
>> that commit, column view sums fail. Poor knowledge of git and elisp
>> prevent me from finding the actual problem, but I did manage to find
>> the first commit were it fails, and this hopefully helps
>>
>> * sum
>>   :PROPERTIES:
>>   :COLUMNS:  %30ITEM %5A{+} %5B{+}
>>   :END:
>> ** bla
>> *** blabla
>>     :PROPERTIES:
>>     :A:        1
>>     :END:
>> ** bli
>>    :PROPERTIES:
>>    :A:        1
>>    :END:
>
> This is fixed. Thank you.
>

Thank you for your quick reaction. Unfortunately it is still not 
perfect. Starting column mode with point on the headline "** bla" makes 
the column view end before headline "** bli". Am I right that this is 
unintended?

Johan

-- 
Johan Sandblom, MD PhD
m +46735521477
What is wanted is not the will to believe, but the
will to find out, which is the exact opposite
--Bertrand Russell

Re: BUG in columns view since 0f93638ce (Jun 2 2015)

[Nicolas Goaziou]

Johan Sandblom <js@ndblom.se> writes:

> Thank you for your quick reaction. Unfortunately it is still not
> perfect. Starting column mode with point on the headline "** bla"
> makes the column view end before headline "** bli". Am I right that
> this is unintended?

This is intended. According to the manual[fn:1] 

     If the cursor is somewhere inside the outline, this command
     searches the hierarchy, up from point, for a ‘:COLUMNS:’ property
     that defines a format. When one is found, the column view table is
     established for the tree starting at the entry that contains the
     ‘:COLUMNS:’ property.

Regards,

[fn:1] (info "(org) Using column view"), first command.

Re: BUG in columns view since 0f93638ce (Jun 2 2015)

[Johan Sandblom]

2015-08-12 01:08 skrev Nicolas Goaziou:
> Johan Sandblom <js@ndblom.se> writes:
>
>> Thank you for your quick reaction. Unfortunately it is still not
>> perfect. Starting column mode with point on the headline "** bla"
>> makes the column view end before headline "** bli". Am I right that
>> this is unintended?
>
> This is intended. According to the manual[fn:1]
>
>      If the cursor is somewhere inside the outline, this command
>      searches the hierarchy, up from point, for a ‘:COLUMNS:’ 
> property
>      that defines a format. When one is found, the column view table 
> is
>      established for the tree starting at the entry that contains the
>      ‘:COLUMNS:’ property.
>
> Regards,
>
> [fn:1] (info "(org) Using column view"), first command.

I read that passage differently. The second-level headline ** bli is in 
the tree that starts at the first-level headline * sum. The manual does 
not state that the column view table is established for the part of the 
tree that is between the entry that contains the ´:COLUMNS:´ property 
and point. Since it does not mention partial trees at all I assumed the 
entire tree starting at the entry was intended.

Johan

-- 
Johan Sandblom, MD PhD
m +46735521477
What is wanted is not the will to believe, but the
will to find out, which is the exact opposite
--Bertrand Russell

Re: BUG in columns view since 0f93638ce (Jun 2 2015)

[Nicolas Goaziou]

Johan Sandblom <js@ndblom.se> writes:

> I read that passage differently. The second-level headline ** bli is
> in the tree that starts at the first-level headline * sum. The manual
> does not state that the column view table is established for the part
> of the tree that is between the entry that contains the ´:COLUMNS:´
> property and point. Since it does not mention partial trees at all
> I assumed the entire tree starting at the entry was intended.

You are right. This is fixed. Thank you.

Regards,