From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` Date: Mon, 24 Aug 2015 15:51:53 +0200 Message-ID: <87k2skaj5y.fsf@petton.fr> References: <20150823191413.17383.23210@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1440431398 12987 80.91.229.3 (24 Aug 2015 15:49:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Aug 2015 15:49:58 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 24 17:49:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTu0J-0004Er-Ai for ged-emacs-devel@m.gmane.org; Mon, 24 Aug 2015 17:49:47 +0200 Original-Received: from localhost ([::1]:53906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTu0I-0000uP-Rx for ged-emacs-devel@m.gmane.org; Mon, 24 Aug 2015 11:49:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTsAK-0008CC-3x for emacs-devel@gnu.org; Mon, 24 Aug 2015 09:52:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTsAG-0006eY-0M for emacs-devel@gnu.org; Mon, 24 Aug 2015 09:52:00 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTsAF-0006eD-TQ for emacs-devel@gnu.org; Mon, 24 Aug 2015 09:51:55 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 437B320CAC for ; Mon, 24 Aug 2015 09:51:55 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Mon, 24 Aug 2015 09:51:55 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=Bg8vYRkfy1TxcJ/yFBVkyP47QFw=; b=gq1cQ ekT0zRkA0UQlINHf52XxQqtZ98k+kdyTcpbn5gVRVxq8AwbhlNCdGxODOsNaNwjj gMbTC0EQ/lQC+QbC/DC8dZfcpfUVbK1V7++JarisAVDMeI1dnyBr3r+rx0/yfxi4 Q7tm2ruZgGP0Nt88YCaYy9aiDT6GRugg9c9n+s= X-Sasl-enc: vwoAEd22AT+goa/sax1tDI/7Hr12z7SgE7kTYehScokl 1440424314 Original-Received: from blueberry (arennes-658-1-104-125.w83-199.abo.wanadoo.fr [83.199.55.125]) by mail.messagingengine.com (Postfix) with ESMTPA id 93516C0001D; Mon, 24 Aug 2015 09:51:54 -0400 (EDT) In-Reply-To: User-Agent: Notmuch/0.19 (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189105 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stefan Monnier writes: >> Remove the calls to `seq-into` from `seq-concatenate` >> Since most new types of seq would have to be defined as sequences (c= ons >> cells or CL structs, mostly), there is no need to convert the seqs to >> sequences (which can be a fairly expensive operation). > > I don't understand this change. Can't it cause two CL-structs to be > vconcat'd together, which wouldn't make much sense? The previous version of `seq-concatenate' did not prevent that, since CL-structs are vectors, thus sequences, and the function was using `sequencep' to determine if the seq had to be converted or not. Nico =2D-=20 Nicolas Petton http://nicolas-petton.fr --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - http://gpgtools.org iQEcBAEBCAAGBQJV2yF5AAoJECM1h6R8IHkQR4IH/04ZCpo6XMzsD9dNdbWDnSBO xIuw6OV8s0whrNE98PbhGF4tEOOjPcvpQft5S1GBJDHQaCDv80gtq4fJjWSRJuO8 p7x2OAHE3Y1Guct6QqA7qlPQQuU19+F8O4gumN1NC51+C1RunE8QUbkCtZsNSc8U 78nVvewaN4ZHzwlY9argxDy63OE0XCBr5p0xyQ0WKx2kQ805vBDTB2uGlkJW01Lm 3XCfroE2noiDhbIoVBKpwZbbMcgQdXVSjkETKPS58AiFH9T/Lt/h7nnyUlQ0whhg UGC2YTfNXVRQfw+Kna10ZHiZEyAYem45fk4VdOTpvNfWLQhRjzaZFWnl7u6zxoc= =DtxN -----END PGP SIGNATURE----- --=-=-=--