Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate`

[Nicolas Petton <nicolas@petton.fr>]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     Remove the calls to `seq-into` from `seq-concatenate`
>>     Since most new types of seq would have to be defined as sequences (cons
>>     cells or CL structs, mostly), there is no need to convert the seqs to
>>     sequences (which can be a fairly expensive operation).
>
> I don't understand this change.  Can't it cause two CL-structs to be
> vconcat'd together, which wouldn't make much sense?

The previous version of `seq-concatenate' did not prevent that, since
CL-structs are vectors, thus sequences, and the function was using
`sequencep' to determine if the seq had to be converted or not.

Nico
-- 
Nicolas Petton
http://nicolas-petton.fr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]