* Re: master 127bafd: Fix setting breakpoints when remote-debugging
[not found] ` <E1Zdykn-0007BO-5u@vcs.savannah.gnu.org>
@ 2015-09-21 12:36 ` Michael Albinus
2015-09-21 18:35 ` Dima Kogan
2015-09-21 18:35 ` bug#13304: " Dima Kogan
0 siblings, 2 replies; 3+ messages in thread
From: Michael Albinus @ 2015-09-21 12:36 UTC (permalink / raw)
To: emacs-devel; +Cc: Dima Kogan
Eli Zaretskii <eliz@gnu.org> writes:
> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
> index 9ab0667..8b5d490 100644
> --- a/lisp/progmodes/gud.el
> +++ b/lisp/progmodes/gud.el
> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line."
> (defun gud-format-command (str arg)
> (let ((insource (not (eq (current-buffer) gud-comint-buffer)))
> (frame (or gud-last-frame gud-last-last-frame))
> + (buffer-file-name-localized
> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name)))
> + (tramp-file-name-localname (tramp-dissect-file-name
> + (buffer-file-name) t))
> + (buffer-file-name)))
Better would be
(buffer-file-name-localized
(and (buffer-file-name)
(or (file-remote-p (buffer-file-name) 'localname)
(buffer-file-name))))
Tramp internal function calls shall be avoided.
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master 127bafd: Fix setting breakpoints when remote-debugging
2015-09-21 12:36 ` master 127bafd: Fix setting breakpoints when remote-debugging Michael Albinus
@ 2015-09-21 18:35 ` Dima Kogan
2015-09-21 18:35 ` bug#13304: " Dima Kogan
1 sibling, 0 replies; 3+ messages in thread
From: Dima Kogan @ 2015-09-21 18:35 UTC (permalink / raw)
To: Michael Albinus; +Cc: 13304, emacs-devel
Michael Albinus <michael.albinus@gmx.de> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index 9ab0667..8b5d490 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line."
>> (defun gud-format-command (str arg)
>> (let ((insource (not (eq (current-buffer) gud-comint-buffer)))
>> (frame (or gud-last-frame gud-last-last-frame))
>> + (buffer-file-name-localized
>> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name)))
>> + (tramp-file-name-localname (tramp-dissect-file-name
>> + (buffer-file-name) t))
>> + (buffer-file-name)))
>
> Better would be
>
> (buffer-file-name-localized
> (and (buffer-file-name)
> (or (file-remote-p (buffer-file-name) 'localname)
> (buffer-file-name))))
>
> Tramp internal function calls shall be avoided.
Hi. Yes, you mentioned that in the bug report (13304), and I updated the
patch in the bug report. Eli committed the older version of the patch by
mistake, however.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#13304: master 127bafd: Fix setting breakpoints when remote-debugging
2015-09-21 12:36 ` master 127bafd: Fix setting breakpoints when remote-debugging Michael Albinus
2015-09-21 18:35 ` Dima Kogan
@ 2015-09-21 18:35 ` Dima Kogan
1 sibling, 0 replies; 3+ messages in thread
From: Dima Kogan @ 2015-09-21 18:35 UTC (permalink / raw)
To: Michael Albinus; +Cc: 13304, emacs-devel
Michael Albinus <michael.albinus@gmx.de> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index 9ab0667..8b5d490 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line."
>> (defun gud-format-command (str arg)
>> (let ((insource (not (eq (current-buffer) gud-comint-buffer)))
>> (frame (or gud-last-frame gud-last-last-frame))
>> + (buffer-file-name-localized
>> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name)))
>> + (tramp-file-name-localname (tramp-dissect-file-name
>> + (buffer-file-name) t))
>> + (buffer-file-name)))
>
> Better would be
>
> (buffer-file-name-localized
> (and (buffer-file-name)
> (or (file-remote-p (buffer-file-name) 'localname)
> (buffer-file-name))))
>
> Tramp internal function calls shall be avoided.
Hi. Yes, you mentioned that in the bug report (13304), and I updated the
patch in the bug report. Eli committed the older version of the patch by
mistake, however.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-21 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150921105525.27576.92526@vcs.savannah.gnu.org>
[not found] ` <E1Zdykn-0007BO-5u@vcs.savannah.gnu.org>
2015-09-21 12:36 ` master 127bafd: Fix setting breakpoints when remote-debugging Michael Albinus
2015-09-21 18:35 ` Dima Kogan
2015-09-21 18:35 ` bug#13304: " Dima Kogan
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.