From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#13304: master 127bafd: Fix setting breakpoints when remote-debugging Date: Mon, 21 Sep 2015 11:35:59 -0700 Message-ID: <87k2rj8vsg.fsf__15612.9600866281$1442860644$gmane$org@secretsauce.net> References: <20150921105525.27576.92526@vcs.savannah.gnu.org> <87io74q79a.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442860644 22600 80.91.229.3 (21 Sep 2015 18:37:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Sep 2015 18:37:24 +0000 (UTC) Cc: 13304@debbugs.gnu.org, emacs-devel@gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 21 20:37:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ze5xf-0003Lw-0m for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2015 20:37:11 +0200 Original-Received: from localhost ([::1]:60420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ze5xe-0003yP-AC for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2015 14:37:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ze5xb-0003yD-FS for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 14:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ze5xW-0004Hw-On for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 14:37:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ze5xW-0004Hs-M8 for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ze5xW-0001ir-Ev for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Sep 2015 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13304 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13304-submit@debbugs.gnu.org id=B13304.14428605696557 (code B ref 13304); Mon, 21 Sep 2015 18:37:02 +0000 Original-Received: (at 13304) by debbugs.gnu.org; 21 Sep 2015 18:36:09 +0000 Original-Received: from localhost ([127.0.0.1]:40643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ze5wf-0001hh-8C for submit@debbugs.gnu.org; Mon, 21 Sep 2015 14:36:09 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38895) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ze5wd-0001hY-Of for 13304@debbugs.gnu.org; Mon, 21 Sep 2015 14:36:08 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 97CC520335 for <13304@debbugs.gnu.org>; Mon, 21 Sep 2015 14:36:07 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 21 Sep 2015 14:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=PTAbQ xGhWlzMs3ZoQ9UKmWhtr/o=; b=vxZ8WwKG0YVkTHoyh8ohLjcInAqoIJBLC7+1m Oygiwgd3yfFG7FyBeevMqd19kotm4zzcD/UOICQl2P2PRXIPqlEZJM/iobDvoSMy nr8x8ctlA8SLMj/VcqfQ4+pmWLfVYoVPyQKXUisOypKnCi1rDcCrfdj8OPsa3vKO QcDDoo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=PTAbQxGhWlzMs3ZoQ9UKmWhtr/o=; b=tbiBa f7rFuZz58GfI/MQrD0zWUbnT9E/hL2uecE6VOPc7v3f6BF1wpDS45WCBIByCidhk ptO/lMGwVROiC8xpGgZ2pCMZhRok3/8M0rJT/UoQCSoWsZogXQyUZ8IjtRJuHsRn AiKUtH/vyyWowKu1ONSleXoWLAV0uZKdbQyIVI= X-Sasl-enc: rYZW8Cm+rRF2xxreIKiy6kz+0rGZuAoebwv3QxRb37i8 1442860567 Original-Received: from shorty.local (unknown [172.56.17.42]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EC94C00013; Mon, 21 Sep 2015 14:36:07 -0400 (EDT) Original-Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1Ze5wV-0007hq-VJ; Mon, 21 Sep 2015 11:36:00 -0700 In-reply-to: <87io74q79a.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106788 Archived-At: Michael Albinus writes: > Eli Zaretskii writes: > >> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el >> index 9ab0667..8b5d490 100644 >> --- a/lisp/progmodes/gud.el >> +++ b/lisp/progmodes/gud.el >> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line." >> (defun gud-format-command (str arg) >> (let ((insource (not (eq (current-buffer) gud-comint-buffer))) >> (frame (or gud-last-frame gud-last-last-frame)) >> + (buffer-file-name-localized >> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name))) >> + (tramp-file-name-localname (tramp-dissect-file-name >> + (buffer-file-name) t)) >> + (buffer-file-name))) > > Better would be > > (buffer-file-name-localized > (and (buffer-file-name) > (or (file-remote-p (buffer-file-name) 'localname) > (buffer-file-name)))) > > Tramp internal function calls shall be avoided. Hi. Yes, you mentioned that in the bug report (13304), and I updated the patch in the bug report. Eli committed the older version of the patch by mistake, however.