From: Dima Kogan <lists@dima.secretsauce.net>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 13304@debbugs.gnu.org, emacs-devel@gnu.org
Subject: bug#13304: master 127bafd: Fix setting breakpoints when remote-debugging
Date: Mon, 21 Sep 2015 11:35:59 -0700 [thread overview]
Message-ID: <87k2rj8vsg.fsf__15612.9600866281$1442860644$gmane$org@secretsauce.net> (raw)
In-Reply-To: <87io74q79a.fsf@gmx.de>
Michael Albinus <michael.albinus@gmx.de> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index 9ab0667..8b5d490 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line."
>> (defun gud-format-command (str arg)
>> (let ((insource (not (eq (current-buffer) gud-comint-buffer)))
>> (frame (or gud-last-frame gud-last-last-frame))
>> + (buffer-file-name-localized
>> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name)))
>> + (tramp-file-name-localname (tramp-dissect-file-name
>> + (buffer-file-name) t))
>> + (buffer-file-name)))
>
> Better would be
>
> (buffer-file-name-localized
> (and (buffer-file-name)
> (or (file-remote-p (buffer-file-name) 'localname)
> (buffer-file-name))))
>
> Tramp internal function calls shall be avoided.
Hi. Yes, you mentioned that in the bug report (13304), and I updated the
patch in the bug report. Eli committed the older version of the patch by
mistake, however.
prev parent reply other threads:[~2015-09-21 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150921105525.27576.92526@vcs.savannah.gnu.org>
[not found] ` <E1Zdykn-0007BO-5u@vcs.savannah.gnu.org>
2015-09-21 12:36 ` master 127bafd: Fix setting breakpoints when remote-debugging Michael Albinus
2015-09-21 18:35 ` Dima Kogan
2015-09-21 18:35 ` Dima Kogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87k2rj8vsg.fsf__15612.9600866281$1442860644$gmane$org@secretsauce.net' \
--to=lists@dima.secretsauce.net \
--cc=13304@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.