From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line Date: Tue, 23 Feb 2016 16:12:42 +1100 Message-ID: <87k2lw1039.fsf@gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456204466 23784 80.91.229.3 (23 Feb 2016 05:14:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 05:14:26 +0000 (UTC) Cc: 21850@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 23 06:14:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aY5Ic-0005yW-Cc for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 06:14:14 +0100 Original-Received: from localhost ([::1]:53934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY5IY-0003de-J5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 00:14:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY5IV-0003bl-7M for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 00:14:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY5IQ-0007pL-5U for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 00:14:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY5IQ-0007pH-2Z for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 00:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aY5IP-0004nZ-VZ for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 00:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 05:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21850-submit@debbugs.gnu.org id=B21850.145620439218362 (code B ref 21850); Tue, 23 Feb 2016 05:14:01 +0000 Original-Received: (at 21850) by debbugs.gnu.org; 23 Feb 2016 05:13:12 +0000 Original-Received: from localhost ([127.0.0.1]:38830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY5Hb-0004m6-RM for submit@debbugs.gnu.org; Tue, 23 Feb 2016 00:13:11 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40228) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY5Ha-0004ly-78 for 21850@debbugs.gnu.org; Tue, 23 Feb 2016 00:13:10 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY5HC-0000ve-E4; Tue, 23 Feb 2016 06:12:47 +0100 In-Reply-To: (Tino Calancha's message of "Sun, 8 Nov 2015 00:00:26 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aY5HC-0000ve-E4 MailScanner-NULL-Check: 1456809167.75406@ZE8CCzO2h8l9PUVkur61/w X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113520 Archived-At: Tino Calancha writes: > Remapped next(previous)-line to ibuffer-forward(backward)-line > > * lisp/ibuffer.el (ibuffer-mode-map): same remap is applied on dired. [...] > diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el > index 89477bd..a81b1cb 100644 > --- a/lisp/ibuffer.el > +++ b/lisp/ibuffer.el > @@ -487,8 +487,10 @@ ibuffer-mode-map > > ;; immediate operations > (define-key map (kbd "n") 'ibuffer-forward-line) > + (define-key map [remap next-line] 'ibuffer-forward-line) > (define-key map (kbd "SPC") 'forward-line) > (define-key map (kbd "p") 'ibuffer-backward-line) > + (define-key map [remap previous-line] 'ibuffer-backward-line) > (define-key map (kbd "M-}") 'ibuffer-forward-next-marked) > (define-key map (kbd "M-{") 'ibuffer-backwards-next-marked) > (define-key map (kbd "l") 'ibuffer-redisplay) In my opinion, we should avoid changing the `next/previous-line' commands unless we have a very good reason for doing so. (For instance, I think it's a mistake that dired remaps those keys.) So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no