bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line

bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line

[Tino Calancha]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]


Remapped next(previous)-line to ibuffer-forward(backward)-line

* lisp/ibuffer.el (ibuffer-mode-map): same remap is applied on dired.

In GNU Emacs 25.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.28)
  of 2015-11-07
Repository revision: 87f49c12573334d1d51048cc69ede7b3c121d4a3
Windowing system distributor 'The X.Org Foundation', version 11.0.11702000
System Description:	Debian GNU/Linux testing (stretch)




[-- Attachment #2: Type: text/plain, Size: 670 bytes --]

diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 89477bd..a81b1cb 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -487,8 +487,10 @@ ibuffer-mode-map
 
     ;; immediate operations
     (define-key map (kbd "n") 'ibuffer-forward-line)
+    (define-key map [remap next-line] 'ibuffer-forward-line)
     (define-key map (kbd "SPC") 'forward-line)
     (define-key map (kbd "p") 'ibuffer-backward-line)
+    (define-key map [remap previous-line] 'ibuffer-backward-line)
     (define-key map (kbd "M-}") 'ibuffer-forward-next-marked)
     (define-key map (kbd "M-{") 'ibuffer-backwards-next-marked)
     (define-key map (kbd "l") 'ibuffer-redisplay)

bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line

[Lars Ingebrigtsen]

Tino Calancha <f92capac@gmail.com> writes:

> Remapped next(previous)-line to ibuffer-forward(backward)-line
>
> * lisp/ibuffer.el (ibuffer-mode-map): same remap is applied on dired.

[...]

> diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
> index 89477bd..a81b1cb 100644
> --- a/lisp/ibuffer.el
> +++ b/lisp/ibuffer.el
> @@ -487,8 +487,10 @@ ibuffer-mode-map
>  
>      ;; immediate operations
>      (define-key map (kbd "n") 'ibuffer-forward-line)
> +    (define-key map [remap next-line] 'ibuffer-forward-line)
>      (define-key map (kbd "SPC") 'forward-line)
>      (define-key map (kbd "p") 'ibuffer-backward-line)
> +    (define-key map [remap previous-line] 'ibuffer-backward-line)
>      (define-key map (kbd "M-}") 'ibuffer-forward-next-marked)
>      (define-key map (kbd "M-{") 'ibuffer-backwards-next-marked)
>      (define-key map (kbd "l") 'ibuffer-redisplay)

In my opinion, we should avoid changing the `next/previous-line'
commands unless we have a very good reason for doing so.  (For instance,
I think it's a mistake that dired remaps those keys.)  So I'm closing
this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no