* bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line
@ 2015-11-07 15:00 Tino Calancha
2016-02-23 5:12 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Tino Calancha @ 2015-11-07 15:00 UTC (permalink / raw
To: 21850; +Cc: Tino Calancha
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
Remapped next(previous)-line to ibuffer-forward(backward)-line
* lisp/ibuffer.el (ibuffer-mode-map): same remap is applied on dired.
In GNU Emacs 25.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.28)
of 2015-11-07
Repository revision: 87f49c12573334d1d51048cc69ede7b3c121d4a3
Windowing system distributor 'The X.Org Foundation', version 11.0.11702000
System Description: Debian GNU/Linux testing (stretch)
[-- Attachment #2: Type: text/plain, Size: 670 bytes --]
diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 89477bd..a81b1cb 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -487,8 +487,10 @@ ibuffer-mode-map
;; immediate operations
(define-key map (kbd "n") 'ibuffer-forward-line)
+ (define-key map [remap next-line] 'ibuffer-forward-line)
(define-key map (kbd "SPC") 'forward-line)
(define-key map (kbd "p") 'ibuffer-backward-line)
+ (define-key map [remap previous-line] 'ibuffer-backward-line)
(define-key map (kbd "M-}") 'ibuffer-forward-next-marked)
(define-key map (kbd "M-{") 'ibuffer-backwards-next-marked)
(define-key map (kbd "l") 'ibuffer-redisplay)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line
2015-11-07 15:00 bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line Tino Calancha
@ 2016-02-23 5:12 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23 5:12 UTC (permalink / raw
To: Tino Calancha; +Cc: 21850
Tino Calancha <f92capac@gmail.com> writes:
> Remapped next(previous)-line to ibuffer-forward(backward)-line
>
> * lisp/ibuffer.el (ibuffer-mode-map): same remap is applied on dired.
[...]
> diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
> index 89477bd..a81b1cb 100644
> --- a/lisp/ibuffer.el
> +++ b/lisp/ibuffer.el
> @@ -487,8 +487,10 @@ ibuffer-mode-map
>
> ;; immediate operations
> (define-key map (kbd "n") 'ibuffer-forward-line)
> + (define-key map [remap next-line] 'ibuffer-forward-line)
> (define-key map (kbd "SPC") 'forward-line)
> (define-key map (kbd "p") 'ibuffer-backward-line)
> + (define-key map [remap previous-line] 'ibuffer-backward-line)
> (define-key map (kbd "M-}") 'ibuffer-forward-next-marked)
> (define-key map (kbd "M-{") 'ibuffer-backwards-next-marked)
> (define-key map (kbd "l") 'ibuffer-redisplay)
In my opinion, we should avoid changing the `next/previous-line'
commands unless we have a very good reason for doing so. (For instance,
I think it's a mistake that dired remaps those keys.) So I'm closing
this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-23 5:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-07 15:00 bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line Tino Calancha
2016-02-23 5:12 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.