all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tino Calancha <f92capac@gmail.com>
Cc: 21850@debbugs.gnu.org
Subject: bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line
Date: Tue, 23 Feb 2016 16:12:42 +1100	[thread overview]
Message-ID: <87k2lw1039.fsf@gnus.org> (raw)
In-Reply-To: <alpine.LRH.2.20.1511072355270.11442@calancha-ilc.kek.jp> (Tino Calancha's message of "Sun, 8 Nov 2015 00:00:26 +0900 (JST)")

Tino Calancha <f92capac@gmail.com> writes:

> Remapped next(previous)-line to ibuffer-forward(backward)-line
>
> * lisp/ibuffer.el (ibuffer-mode-map): same remap is applied on dired.

[...]

> diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
> index 89477bd..a81b1cb 100644
> --- a/lisp/ibuffer.el
> +++ b/lisp/ibuffer.el
> @@ -487,8 +487,10 @@ ibuffer-mode-map
>  
>      ;; immediate operations
>      (define-key map (kbd "n") 'ibuffer-forward-line)
> +    (define-key map [remap next-line] 'ibuffer-forward-line)
>      (define-key map (kbd "SPC") 'forward-line)
>      (define-key map (kbd "p") 'ibuffer-backward-line)
> +    (define-key map [remap previous-line] 'ibuffer-backward-line)
>      (define-key map (kbd "M-}") 'ibuffer-forward-next-marked)
>      (define-key map (kbd "M-{") 'ibuffer-backwards-next-marked)
>      (define-key map (kbd "l") 'ibuffer-redisplay)

In my opinion, we should avoid changing the `next/previous-line'
commands unless we have a very good reason for doing so.  (For instance,
I think it's a mistake that dired remaps those keys.)  So I'm closing
this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2016-02-23  5:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07 15:00 bug#21850: 25.0.50; Remapped next(previous)-line to ibuffer-for(back)ward-line Tino Calancha
2016-02-23  5:12 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2lw1039.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=21850@debbugs.gnu.org \
    --cc=f92capac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.