From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#19559: 24.3; C-n in doc-view-mode Date: Wed, 16 Mar 2016 19:30:09 +0100 Message-ID: <87k2l2gtse.fsf@mbork.pl> References: <87r3v2ifs5.fsf@robertthorpeconsulting.com> <87wpp5uzr3.fsf@mbork.pl> <834mc9dob2.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1458153086 10428 80.91.229.3 (16 Mar 2016 18:31:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Mar 2016 18:31:26 +0000 (UTC) Cc: 19559@debbugs.gnu.org, rt@robertthorpeconsulting.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 16 19:31:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1agGDw-0007kF-SF for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Mar 2016 19:31:12 +0100 Original-Received: from localhost ([::1]:58116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agGDs-0000kU-TD for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Mar 2016 14:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agGDp-0000gx-DJ for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2016 14:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agGDm-00067x-4b for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2016 14:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agGDm-00067t-1C for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2016 14:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1agGDl-0007jt-R4 for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2016 14:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2016 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19559-submit@debbugs.gnu.org id=B19559.145815302129697 (code B ref 19559); Wed, 16 Mar 2016 18:31:01 +0000 Original-Received: (at 19559) by debbugs.gnu.org; 16 Mar 2016 18:30:21 +0000 Original-Received: from localhost ([127.0.0.1]:50433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agGD7-0007iv-95 for submit@debbugs.gnu.org; Wed, 16 Mar 2016 14:30:21 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:46806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agGD5-0007im-Aw for 19559@debbugs.gnu.org; Wed, 16 Mar 2016 14:30:20 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 4736AA17795; Wed, 16 Mar 2016 19:30:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8WAZ-tz4O-mi; Wed, 16 Mar 2016 19:30:13 +0100 (CET) Original-Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 7B516A1778F; Wed, 16 Mar 2016 19:30:13 +0100 (CET) User-agent: mu4e 0.9.13; emacs 25.1.50.7 In-reply-to: <834mc9dob2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114980 Archived-At: --=-=-= Content-Type: text/plain On 2016-03-14, at 17:20, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Date: Mon, 14 Mar 2016 11:20:48 +0100 >> Cc: 19559@debbugs.gnu.org >> >> I attach a patch prepared using git-format-patch. It's my first patch >> for Emacs, so please let me know if I did it correctly (especially wrt >> the commit message). > > Looks good to me, but please prepare the commit message in the > ChangeLog format. "C-x 4 a" with point inside the function you > changed is a good start. Is it better now? > Thanks. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-bug-19559.patch >From e31779e8c88aa1b83a90af386b0049d1f65ce6a2 Mon Sep 17 00:00:00 2001 From: Marcin Borkowski Date: Mon, 14 Mar 2016 11:15:10 +0100 Subject: [PATCH] Fix bug #19559 2016-03-16 Marcin Borkowski * lisp/doc-view.el (doc-view-next-line-or-next-page): Take the prefix argument into consideration when continuous scrolling is not in effect (i.e., by default). --- lisp/doc-view.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 9d912c3..223565c 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -626,7 +626,7 @@ doc-view-next-line-or-next-page (image-bob) (image-bol 1)) (set-window-hscroll (selected-window) hscroll))) - (image-next-line 1))) + (image-next-line arg))) (defun doc-view-previous-line-or-previous-page (&optional arg) "Scroll downward by ARG lines if possible, else goto previous page. -- 2.4.3 --=-=-=--