all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19559@debbugs.gnu.org, rt@robertthorpeconsulting.com
Subject: bug#19559: 24.3; C-n in doc-view-mode
Date: Wed, 16 Mar 2016 19:30:09 +0100	[thread overview]
Message-ID: <87k2l2gtse.fsf@mbork.pl> (raw)
In-Reply-To: <834mc9dob2.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]


On 2016-03-14, at 17:20, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Marcin Borkowski <mbork@mbork.pl>
>> Date: Mon, 14 Mar 2016 11:20:48 +0100
>> Cc: 19559@debbugs.gnu.org
>> 
>> I attach a patch prepared using git-format-patch.  It's my first patch
>> for Emacs, so please let me know if I did it correctly (especially wrt
>> the commit message).
>
> Looks good to me, but please prepare the commit message in the
> ChangeLog format.  "C-x 4 a" with point inside the function you
> changed is a good start.

Is it better now?

> Thanks.

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-bug-19559.patch --]
[-- Type: text/x-patch, Size: 944 bytes --]

From e31779e8c88aa1b83a90af386b0049d1f65ce6a2 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Mon, 14 Mar 2016 11:15:10 +0100
Subject: [PATCH] Fix bug #19559

2016-03-16  Marcin Borkowski  <mbork@mbork.pl>

	* lisp/doc-view.el (doc-view-next-line-or-next-page): Take the
	prefix argument into consideration when continuous scrolling is
	not in effect (i.e., by default).
---
 lisp/doc-view.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 9d912c3..223565c 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -626,7 +626,7 @@ doc-view-next-line-or-next-page
 	    (image-bob)
 	    (image-bol 1))
 	  (set-window-hscroll (selected-window) hscroll)))
-    (image-next-line 1)))
+    (image-next-line arg)))
 
 (defun doc-view-previous-line-or-previous-page (&optional arg)
   "Scroll downward by ARG lines if possible, else goto previous page.
-- 
2.4.3


  reply	other threads:[~2016-03-16 18:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-10 19:42 bug#19559: 24.3; C-n in doc-view-mode Robert Thorpe
2016-03-14 10:20 ` Marcin Borkowski
2016-03-14 16:20   ` Eli Zaretskii
2016-03-16 18:30     ` Marcin Borkowski [this message]
2016-03-17 17:08       ` Eli Zaretskii
2016-03-18 21:08       ` Tassilo Horn
2016-03-18 21:16         ` Marcin Borkowski
2016-03-18 21:52           ` Tassilo Horn
2016-03-15  0:35   ` Robert Thorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2l2gtse.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=19559@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rt@robertthorpeconsulting.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.