From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results Date: Wed, 11 May 2016 23:48:43 +0300 Organization: LINKOV.NET Message-ID: <87k2j0b9sk.fsf@mail.linkov.net> References: <86d1owl682.fsf@yandex.ru> <87inyoxpz8.fsf@mail.linkov.net> <8760unxaoi.fsf@mail.linkov.net> <118c4316-9179-c9dd-e7d1-97b96921d922@yandex.ru> <8737pp1tt6.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1462999946 12894 80.91.229.3 (11 May 2016 20:52:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 May 2016 20:52:26 +0000 (UTC) Cc: 23484@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 11 22:52:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0b75-0003A3-Hw for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 22:52:11 +0200 Original-Received: from localhost ([::1]:54027 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0b74-00042D-Pg for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 16:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0b70-0003yV-DC for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 16:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0b6w-0006wj-3v for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 16:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0b6w-0006wV-07 for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 16:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0b6v-0006HA-L3 for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 May 2016 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23484-submit@debbugs.gnu.org id=B23484.146299990324099 (code B ref 23484); Wed, 11 May 2016 20:52:01 +0000 Original-Received: (at 23484) by debbugs.gnu.org; 11 May 2016 20:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:47685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0b6c-0006Gd-U7 for submit@debbugs.gnu.org; Wed, 11 May 2016 16:51:43 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:39325 helo=homiemail-a39.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0b6a-0006GO-GG for 23484@debbugs.gnu.org; Wed, 11 May 2016 16:51:40 -0400 Original-Received: from homiemail-a39.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a39.g.dreamhost.com (Postfix) with ESMTP id 4CF2315006D; Wed, 11 May 2016 13:51:39 -0700 (PDT) Original-Received: from localhost.linkov.net (85.253.169.195.cable.starman.ee [85.253.169.195]) (Authenticated sender: jurta@jurta.org) by homiemail-a39.g.dreamhost.com (Postfix) with ESMTPA id 6C4D9150069; Wed, 11 May 2016 13:51:38 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Wed, 11 May 2016 01:03:14 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118142 Archived-At: >>> - Being able to replace _any_ regexp inside the matches is a feature >>> (though maybe it's not going to be very popular). >> >> Honestly speaking, the =E2=80=98.*=E2=80=99 thing is quite confusing. > > You're probably right. We could provide a separate command with that > advanced feature (or only use ask for FROM with prefix argument). We wo= uld > still have `.*' under the covers in the default case, though. What is the purpose of asking FROM? If to be able to replace a substring of the original xref search string, then anyway it's inconvenient for the user to type a part of the already typed string again, e.g. after searching with xref for the string =E2=80=9Cabracadabra= =E2=80=9D, pressing =E2=80=98r=E2=80=99 requires typing a substring =E2=80=9Cabracad= abr=E2=80=9D, etc. More useful would be to prefill the original string in the minibuffer (here INITIAL-CONTENTS of read-from-minibuffer is justified) for easy editing (removing parts of the xref search string). This will greatly simplify replacement with perform-replace. And then why limit to only boundaries of matches? The user sees a list of matching lines in the *xref* buffer. Let's allow the users to replace any text within the displayed matching lines (WYSIWYG).