From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: master c430f7e breaks diff-mode fontification Date: Mon, 27 Jun 2016 11:22:50 +0200 Message-ID: <87k2hbasut.fsf_-_@gmx.net> References: <20160623212912.4921.57688@vcs.savannah.gnu.org> <20160623212913.536AF220129@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467019941 9788 80.91.229.3 (27 Jun 2016 09:32:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2016 09:32:21 +0000 (UTC) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 27 11:32:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bHStl-0002tw-JE for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2016 11:32:09 +0200 Original-Received: from localhost ([::1]:57399 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHSlg-0007U6-Ue for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2016 05:23:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHSkt-0007Pk-8x for emacs-devel@gnu.org; Mon, 27 Jun 2016 05:23:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHSkp-0000kk-15 for emacs-devel@gnu.org; Mon, 27 Jun 2016 05:22:58 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:63705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHSko-0000iG-Na for emacs-devel@gnu.org; Mon, 27 Jun 2016 05:22:54 -0400 Original-Received: from rosalinde ([89.245.117.123]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MWwp6-1aneG723lM-00Vtzn; Mon, 27 Jun 2016 11:22:51 +0200 In-Reply-To: <20160623212913.536AF220129@vcs.savannah.gnu.org> (Mark Oteiza's message of "Thu, 23 Jun 2016 21:29:13 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:/waWZaaRtFTtnpgXaA6HBPMUK7z/lPVXbGE656BCnen3pxjqNGe cWDVLN0ETh6wCcYvTrKN/CHfwm9vQCGOjj3cQv4wOZPPL7uf64wLGGr21Sr8xdHeD/fLLa5 uzitWGmiGTnk2DIq2WNDB9j1KnKwQ0tzWDoijCgDKnZnpex4OzhVY5s7ZB0Htvys94zWDzn gPHcaL9qsgRI+clnxh0VQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:yoZ0W+XPxl8=:NnkbPw6xOcgAvbrHAY5rtj 2hfV8Sg7mA5W4fCDkmdAuW4/anIcAx2DMUfFJBpafhXPI7lK4B9i/bPR6PVYOsX4BfDyHGWkj luCp6wqgpNJxDEBlW52+VSALw04cwqoYwjg3NMg7KXOUb6HaduFKRt7UgqgVZHvA3oK2TT2C+ cmMWsb9pHdrO6rzSw+9CcInrR+v8WGhntC4q59UvUHej8NE932pdIw+0DY1d24+OFimYfj78g RClqmqgWbtKvbNXpEpOPfWFmfI22WzCfJzYlwqtTcHxZ7s4h2An/0pDzYyDi05O1QM6n857rW BEEVA/rdBIg6tY3S4iPs753A6Zd0PdMJlHMgB56M5S9gdset7rKeaEG4oIgjRDRSAOTaIp4Ns C/O2+uM6t5tHEjPEeL308sqqGGp9MZ3VblYPdVHQ+XqLOE6TTOeO4O2V8c2Nnso4wlIXiMlQC cd9xbfX+TQApCxHnM0Fl7wehalJWqtLiuCDqI3MS/vFN4etrInjXY8HDQVkY1/Vcr7YadF0OC uEYuUndAxb5BLUfKMN5d4z4D7z6URVOFeC8w9fUBeO6zFBTV+nVGs03RYAqGA4eUuycXR4whO WqKHztAk3GNug6E5Mz1YR6M/JVDuxfXLq/wwrPMGW8CCfciqpUMIRgwhsTSXnDDPHTiZ7yX6O jwrQsMwBs9pZr4xiyQ6jdJ9sGl+uR9GSkAUfPgqFfiHt42MOe8o7SQxp6pqoZCVUW88k9T1yF urE8bytwbd7bfSF344q9Gq6ddQbIMpwDa5jBRdZnkQmNA8cYKT2LhuMJ+yb8TMUSE2oTayM4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204798 Archived-At: This change breaks diff-mode fontification: > branch: master > commit c430f7e23fc2c22f251ace4254e37dea1452dfc3 > Author: Mark Oteiza > Commit: Mark Oteiza > > Remove some face aliases obsoleted in 22.1 To reproduce (after git pull and make bootstrap): 0. emacs -Q 1. C-x v L RET RET 2. In the *vc-change-log* buffer type `d' on one of the entries. => The diff displayed in the *vc-diff* buffer lack the expected faces on the removed and added lines, and the *Messages* buffer contains these messages: Error during redisplay: (jit-lock-function 1) signaled (void-variable diff-hunk-header) Error during redisplay: (jit-lock-function 501) signaled (void-variable diff-removed) Error during redisplay: (jit-lock-function 1001) signaled (void-variable diff-hunk-header) Error during redisplay: (jit-lock-function 1501) signaled (void-variable diff-context) If prior to step 1 above I evaluate the file diff-mode.el from emacs-25 (i.e. the version before the above commit), then after 2 the *vc-diff* buffer is fontified as expected and there no such error messages in *Messages*. Steve Berman