From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Thu, 07 Jul 2016 13:55:40 +0100 Message-ID: <87k2gx4ng3.fsf@russet.org.uk> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <83eg76n5h5.fsf@gnu.org> <87y45eeoor.fsf@lifelogs.com> <577D42BB.1020500@cs.ucla.edu> <87oa694rfw.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467896165 25610 80.91.229.3 (7 Jul 2016 12:56:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 12:56:05 +0000 (UTC) Cc: Paul Eggert , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 14:55:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bL8qQ-0003pm-LV for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 14:55:54 +0200 Original-Received: from localhost ([::1]:39690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8qP-0001H9-M2 for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 08:55:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8qJ-0001BJ-Fc for emacs-devel@gnu.org; Thu, 07 Jul 2016 08:55:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL8qF-0006xc-82 for emacs-devel@gnu.org; Thu, 07 Jul 2016 08:55:46 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:36593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8qE-0006wu-TS for emacs-devel@gnu.org; Thu, 07 Jul 2016 08:55:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=VTXhgSw4vL0AYyB5Lazd46+oZhrpD1o1Rwak3GT2TsM=; b=Fq7qqQikSgi1DsmefQ5nxXqP3z 5m32eCagIYrSnBo9YU2j5IYaJ06FtkpqGpwfSZf0jG0GnmeSzFx/81Hisuv7gK7sx0Q5hGTW6/Qhp M0vV0tCjmr/oowtM1UPD8bUY7KfyDcQH6s0F85XL2svgFEatF3AyVztTLkusdn9NytPG/D9GF8hrB lSm++/n0Pm+voh6WjBWyhR3+d5yOoY+K+o2N+Xqk4gaTEnoqqJmQQfKRP0yOw2MNYAQoTMebk4XmQ XyqFD33a3DBNety/B37+0ezr5RlnHp3cQu6W/j0/hb71nq1gklg58KqFth2xkS609Yx/AimCOgXdr iPNjHAkA==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:32706 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bL8qD-000T1B-Fs; Thu, 07 Jul 2016 13:55:41 +0100 In-Reply-To: (Noam Postavsky's message of "Thu, 7 Jul 2016 08:43:30 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205314 Archived-At: Noam Postavsky writes: > On Thu, Jul 7, 2016 at 7:29 AM, Phillip Lord wrote: >> At the moment, we have a poor workflow for supporting this. >> >> - I can push a branch onto the Emacs git. But, this is not squashable, >> so the final state before the merge is hard to do >> - There is no system for queuing pull requests, so sometimes things get >> forgotten >> - I can send patches, but this is clunk compared to pushing a branch >> within version control. >> - There is no system for viewing feedback about an individual patch. >> - There is no system for adding inline comments to patches > > So maybe we just need some more support in vc-git to make sending > patches less clunky? Yes, that would help, assuming that it's not there already. But, again, I still feel that patches are fairly "old school". > I've been sending patches to bug threads, and often getting useful > feedback on them (and since it's by email, the comments can easily be > inline). Personally, I don't find it more clunky than pushing to a > branch, and then opening a PR in a web browser. This is true for the first patch, but not true for additional commits. > Yes, some patches are forgotten, but I don't see how a PR "system" > makes that less likely to happen, e.g., cask has a bunch of open PRs > sitting around: https://github.com/cask/cask/pulls. I think you have just demonstrated my point. You found out all the outstanding ones also. >> Perhaps, as a half way house, we could use the resources that we have. >> PRs could go to the bug reporting system. This will, at least, keep all >> the conversations in one place. If we can tag these with "has patch" >> here as well, it will give an queue also. > > I thought that was the current system. Here is the queue: > http://debbugs.gnu.org/cgi/pkgreport.cgi?package=emacs;include=tags%3Apatch;bug-rev=on Again, also my point. Phil