From: Michael Heerdegen <michael_heerdegen@web.de>
To: Robert Cochran <robert-emacs@cochranmail.com>
Cc: Chunyang Xu <xuchunyang.me@gmail.com>, 24362@debbugs.gnu.org
Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let*
Date: Thu, 15 Sep 2016 23:36:21 +0200 [thread overview]
Message-ID: <87k2ecalre.fsf@web.de> (raw)
In-Reply-To: <87fup2nkry.fsf@cochranmail.com> (Robert Cochran's message of "Wed, 14 Sep 2016 16:06:57 -0700")
Robert Cochran <robert-emacs@cochranmail.com> writes:
> This patch changes the pcase-let* docstring to match the pcase-let
> docstring, but IMO I don't think that the phrase 'a list of
> expressions' is exactly the right term for this. That (to me) implies
> that we are wrapping the whole body in a list, which you don't.
Isn't this just normal "Elisp speak" for a &rest parameter? Sure, the
value of the parameter doesn't appear in the code (only "spliced in") -
but we use this wording all the time.
> diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
> index 0b8dddf..2d61642 100644
> --- a/lisp/emacs-lisp/pcase.el
> +++ b/lisp/emacs-lisp/pcase.el
> @@ -261,7 +261,7 @@ pcase--let*
> ;;;###autoload
> (defmacro pcase-let* (bindings &rest body)
> "Like `let*' but where you can use `pcase' patterns for bindings.
> -BODY should be an expression, and BINDINGS should be a list of bindings
> +BODY should be a list of expressions, and BINDINGS should be a list of bindings
Looks ok to me.
Michael.
next prev parent reply other threads:[~2016-09-15 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 4:26 bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Chunyang Xu
2016-09-14 23:06 ` Robert Cochran
2016-09-15 21:36 ` Michael Heerdegen [this message]
2016-09-15 21:57 ` Robert Cochran
2016-09-15 22:00 ` Drew Adams
2016-09-15 22:40 ` Michael Heerdegen
2016-09-23 16:26 ` Michael Heerdegen
2016-09-23 20:45 ` Robert Cochran
2016-09-25 14:32 ` Michael Heerdegen
2016-09-26 23:39 ` Robert Cochran
2019-11-08 3:43 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ecalre.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=24362@debbugs.gnu.org \
--cc=robert-emacs@cochranmail.com \
--cc=xuchunyang.me@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.