From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords Date: Sun, 18 Sep 2016 10:04:50 -0400 Message-ID: <87k2e9z4l9.fsf@users.sourceforge.net> References: <87oa3l7ku4.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1474207584 24304 195.159.176.226 (18 Sep 2016 14:06:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Sep 2016 14:06:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24456@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 18 16:06:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blcjb-0005g2-3U for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Sep 2016 16:06:19 +0200 Original-Received: from localhost ([::1]:50239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blcjc-0000Sx-E5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Sep 2016 10:06:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blciR-00081y-6X for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2016 10:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blciM-0003tT-Ub for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2016 10:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blciM-0003tD-R2 for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2016 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1blciM-0005kY-DZ for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2016 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2016 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24456-submit@debbugs.gnu.org id=B24456.147420747522062 (code B ref 24456); Sun, 18 Sep 2016 14:05:02 +0000 Original-Received: (at 24456) by debbugs.gnu.org; 18 Sep 2016 14:04:35 +0000 Original-Received: from localhost ([127.0.0.1]:34442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blchv-0005jg-1w for submit@debbugs.gnu.org; Sun, 18 Sep 2016 10:04:35 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:36346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blchs-0005jM-Ri; Sun, 18 Sep 2016 10:04:33 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id o3so49029608ita.1; Sun, 18 Sep 2016 07:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/3p5eVCif1vJndL1EL4FRxn4GCU68OLTMO30ZVtecZY=; b=Kie1JG04vhRXtCfuvpv9RSdi8RzhY5v0y3HY/0RTmdQZFMiwWrxru2TvXv8w87koJ1 S+k54X0SpIliGixGfTILmZDp+MkAwz2KN9bCUbNkgIXO4Ym715jBRML9NXDciCPJjui6 Fd0pfM3k/phlzN5FbTCn3Om1cWmYaLj6MQm9RYO/vtVZDYdHib8AdcqonPzi0TI/aBG+ VTvkkRqmAfmIkUOQ3pR67li76+r8nvxz7kI+94rvNvAxJX2EsDXInPYwUiTCUb+/DMHd BijWkyQt+UgmHVYNfyQBXmXyt4yIWFFyKx4ewbFp0c2dcLeDJB8YSD1Ds+HvC6AAmXhX elOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/3p5eVCif1vJndL1EL4FRxn4GCU68OLTMO30ZVtecZY=; b=MzDuoM4LovZFdTpFW7OA6/vcECl2HVO82sC6xPGj6LTr0qMz88ai6/q+5LxROWr2K1 feBRzTRh7mjZgLfI4KAmtPZsKUF2pA7TGMAj+mcYW7b2jCUN8Ovl90oxvxpzMFRmMoA6 AMSURstkOXb4zKfz5g00WUEl4B4VCBLf+nHHJJOFePnhzn3BCgXvERLecYpdMGoAZ1w3 sdi5XckgbG+H01guj7gzhO/INy19exsL7/8pwy2m2mGirhPFZhDO4Ph9JL7zS1FliY4A +iuYjF85/l1oAr/d/jPPGmovnavNHelYiDHpwjkOpF1q8F103W1J57BYQU7YR6i2vohB 5hBg== X-Gm-Message-State: AE9vXwOj/ttjp3TFPBeJEgTsdp5ndqMgpsBjH15N1N/XVPWJx7Fl16dPKcxmY08DTnDmSw== X-Received: by 10.36.39.195 with SMTP id g186mr5827294ita.53.1474207467163; Sun, 18 Sep 2016 07:04:27 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id f14sm6525318ita.10.2016.09.18.07.04.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Sep 2016 07:04:26 -0700 (PDT) In-Reply-To: <87oa3l7ku4.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 18 Sep 2016 00:01:23 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123415 Archived-At: forcemerge 4931 24456 quit Dima Kogan writes: > > In a console on Debian it looks like Control+Shift+s produces C-s > regardless of caps-lock, but I suspect this has a deeper cause than what > this patch touches. Yeah, I think for terminals the keystrokes have to fit in bytes, so there is no room for both a Ctrl and Shift bit to be set. > > > I have tested this patch on gtk (fixes it) and the console (doesn't > change anything). Hopefully it makes osx work properly while letting > windows builds keep working. After applying the patch to emacs-25, I built --with-x-toolkit=lucid and --enable-checking; I get an assertion violation when hitting C-n with capslock on. In GNU Emacs 25.1.28 (x86_64-unknown-linux-gnu, X toolkit) of 2016-09-18 built on zony Repository revision: 76981c4457682ae8699789b334a3be7b60ad301d Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 Configured using: 'configure --cache-file=../debug-config.cache 'CFLAGS=-O0 -g3 -march=native' --enable-checking MAKEINFO=makeinfo-4.13a --with-x-toolkit=lucid --without-toolkit-scroll-bars --with-gif=no --with-jpeg=no' #0 terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:354 #1 0x00000000005fa996 in die (msg=0x7273e6 "c == event->code", file=0x7259b0 "keyboard.c", line=5415) at alloc.c:7223 #2 0x000000000057d40e in make_lispy_event (event=0xd2ab68 ) at keyboard.c:5415 #3 0x000000000057a2e3 in kbd_buffer_get_event (kbp=0x7fffffffddc8, used_mouse_menu=0x7fffffffe3af, end_time=0x0) at keyboard.c:4071 #4 0x000000000057514a in read_event_from_main_queue (end_time=0x0, local_getcjmp=0x7fffffffe170, used_mouse_menu=0x7fffffffe3af) at keyboard.c:2148 #5 0x0000000000575410 in read_decoded_event_from_main_queue (end_time=0x0, local_getcjmp=0x7fffffffe170, prev_event=0, used_mouse_menu=0x7fffffffe3af) at keyboard.c:2211 #6 0x0000000000576fa7 in read_char (commandflag=1, map=28530083, prev_event=0, used_mouse_menu=0x7fffffffe3af, end_time=0x0) at keyboard.c:2799 #7 0x0000000000585fe3 in read_key_sequence (keybuf=0x7fffffffe560, bufsize=30, prompt=0, dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true, prevent_redisplay=false) at keyboard.c:9089 #8 0x00000000005730f0 in command_loop_1 () at keyboard.c:1365 #9 0x000000000061a8c2 in internal_condition_case (bfun=0x572cb4 , handlers=19056, hfun=0x572346 ) at eval.c:1309 #10 0x00000000005728f6 in command_loop_2 (ignore=0) at keyboard.c:1107 #11 0x0000000000619e91 in internal_catch (tag=45840, func=0x5728cd , arg=0) at eval.c:1074 #12 0x0000000000572898 in command_loop () at keyboard.c:1086 #13 0x0000000000571e36 in recursive_edit_1 () at keyboard.c:692 #14 0x0000000000572036 in Frecursive_edit () at keyboard.c:763 #15 0x000000000056fde3 in main (argc=2, argv=0x7fffffffe9f8) at emacs.c:1626