From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [org-src, patch] colored source blocks
Date: Thu, 22 Sep 2016 09:21:33 +0200 [thread overview]
Message-ID: <87k2e4s8le.fsf@gmx.us> (raw)
In-Reply-To: 878tulqqmm.fsf@gmail.com
Hi Aaron,
Thanks for the feedback.
Aaron Ecay <aaronecay@gmail.com> writes:
> The patch in general LGTM. One comment/question, though:
>
> 2016ko irailak 21an, Rasmus-ek idatzi zuen:
>
> [...]
>
>
>> +(defcustom org-src-block-faces nil
>> + "Alist of faces to be used for source-block.
>> +Each element is a cell of the format
>> +
>> + (\"language\" FACE-OR-BACKGROUND)
>> +
>> +Where FACE-OR-BACKGROUND is either a face, an anonymous face, or
>> +a string corresponding to a background color.
>
> Why do you support a background color string here?
Over-engineering?
> I think that it’s easy to specify faces which consist of a background
> color only both in lisp [(:background "XXX") vs. "XXX"] and via the
> customize interface. So this flexibility seems to just introduce
> additional complications for virtually no benefit in usability. But
> maybe I’m missing something...?
The "only" reason was that I imagine that some might prefer not to get
into anonymous faces. But then, there’s an example right there in the
docstring so maybe it’s assuming too little of our friends...
I’ll remove -OR-BACKGROUND and push.
Thanks,
Rasmus
--
This is the kind of tedious nonsense up with which I will not put
prev parent reply other threads:[~2016-09-22 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 10:27 [org-src, patch] colored source blocks Rasmus
2016-09-21 14:22 ` Aaron Ecay
2016-09-22 7:21 ` Rasmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2e4s8le.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.