From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#18131: 24.4.50; View-search-... skips all matches between (point) and edge of window Date: Sat, 24 Dec 2016 22:43:04 -0800 Message-ID: <87k2aoecg7.fsf@secretsauce.net> References: <878undtl18.fsf@secretsauce.net> <87bn77oboa.fsf@gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482648266 8606 195.159.176.226 (25 Dec 2016 06:44:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Dec 2016 06:44:26 +0000 (UTC) User-Agent: mu4e 0.9.17; emacs 26.0.50.1 Cc: 18131@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 25 07:44:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cL2XY-0000cr-1e for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Dec 2016 07:44:16 +0100 Original-Received: from localhost ([::1]:45903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL2XZ-0003rK-FD for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Dec 2016 01:44:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL2XO-0003pz-AO for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 01:44:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cL2XK-0007SS-NH for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 01:44:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cL2XK-0007SM-Ho for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 01:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cL2XK-0006Tk-8h for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 01:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Dec 2016 06:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18131-submit@debbugs.gnu.org id=B18131.148264819724833 (code B ref 18131); Sun, 25 Dec 2016 06:44:02 +0000 Original-Received: (at 18131) by debbugs.gnu.org; 25 Dec 2016 06:43:17 +0000 Original-Received: from localhost ([127.0.0.1]:54249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cL2WX-0006SQ-Dk for submit@debbugs.gnu.org; Sun, 25 Dec 2016 01:43:17 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cL2WS-0006SC-LA for 18131@debbugs.gnu.org; Sun, 25 Dec 2016 01:43:12 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A6BC92086C; Sun, 25 Dec 2016 01:43:06 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 25 Dec 2016 01:43:06 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=6HhHCVVhX1ZVA9LcFn8QZZQfw9Q=; b=tP9d/w xOfl3A2waBsTtHOGna+4QfCABzOH/z86dJvERrANbq18GMbzDDTZeYqwa221htdd A9uDj9No+Af1YneIsr00QGbozBbIn2g0gAuLtlBAwnCd9JC2NSF1vdFB5waxISNG Ix7ykKf1nxl7URPjt3OR71rBOSqGYabsBIH0o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=6HhHCVVhX1ZVA9 LcFn8QZZQfw9Q=; b=k/NrJqB2RvBBtPtw5n+sVbnzgshJu6ttMJgg+mJVvgnMr5 VHDPEvm8yRCjJk7V+6liW7eLaFF6YXjQQsSJs35OYoYGtWYHy4wsVnS6CO49zSGz D8BLuXBD3k+UyGE3cNXq54EclgHkmsXBQg11JYsSZdkO7A3zYxdofdQCnHBkk= X-ME-Sender: X-Sasl-enc: KehivCl3ua+pAEj7pi+VjTQiri4zi0lT+tyT57Laru7X 1482648186 Original-Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 514EB2461E; Sun, 25 Dec 2016 01:43:06 -0500 (EST) Original-Received: from dima by shorty.local with local (Exim 4.87) (envelope-from ) id 1cL2WO-0003CB-Sf; Sat, 24 Dec 2016 22:43:04 -0800 In-reply-to: <87bn77oboa.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127430 Archived-At: Lars Ingebrigtsen writes: > Dima Kogan writes: > >> The emacs view-mode has navigation with 'n' and 'p' keys to navigate by >> searching (like isearch, but with fewer keystrokes and very similar to >> less and vi). >> >> I just discovered that unlike less and vi, this view-mode navigation >> doesn't hit all the matches, but rather skips the ones between (point) >> and the edge of the window. This ensures that any matches that are >> visible by the user (but not highlighted by view-mode) are skipped. >> >> This clearly was a design choice, rather than a bug. However, the >> documentation doesn't mention this, and I think it is counterintuitive. >> Attaching a very simple patch to fix. > > [...] > >> - (move-to-window-line (if (< times 0) 0 -1))) > > If this was a design choice, then we should perhaps ask the person who > designed it what it's all about... which isn't easy in this instance, > since this is very old code. > > Does anybody have an opinion here? Can we revisit this? I think view-mode behaving like 'less' does would be an improvement.