From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alexey Lebedeff <binarin@gmail.com>
Cc: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Tag visibility fixup after setting them
Date: Thu, 29 Dec 2016 16:41:48 +0100 [thread overview]
Message-ID: <87k2ain3nn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADOt_n-aHF1XFYETt1OY2q7WuA3XzQ2yLdFKKEKYny=bAygxMQ@mail.gmail.com> (Alexey Lebedeff's message of "Thu, 29 Dec 2016 16:11:29 +0300")
Hello,
Alexey Lebedeff <binarin@gmail.com> writes:
> I'm attaching updated patch.
Applied. Thank you.
> But I'm not sure it's a good idea to add another 6 lines of code to
> the function which is already big enough.
The function is not massive either, and half the inserted lines are
comments anyway.
Besides, I tweaked the change so that it fits in a single loc (excluding
comments).
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2016-12-29 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:30 [PATCH] Tag visibility fixup after setting them Alexey Lebedeff
2016-12-29 0:39 ` Nicolas Goaziou
2016-12-29 13:11 ` Alexey Lebedeff
2016-12-29 15:41 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ain3nn.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=binarin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.