From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.devel Subject: Re: Overlays as an AA-tree Date: Fri, 05 May 2017 22:39:13 +0200 Message-ID: <87k25v11ji.fsf@luca> References: <87d1jylv43.fsf@fastmail.com> <87shnppspb.fsf@hochschule-trier.de> <87o9yc9v30.fsf@hochschule-trier.de> <87a89vaes3.fsf@hochschule-trier.de> <87efz7n0g5.fsf@fastmail.com> <877f4uah6i.fsf@hochschule-trier.de> <83k28u1uyz.fsf@gnu.org> <871suxs9ad.fsf@hochschule-trier.de> <837f4pxpdc.fsf@gnu.org> <877f4lls9e.fsf@hochschule-trier.de> <838tp0q3k8.fsf@gnu.org> <87vas4owus.fsf@luca> <87r32rpfhv.fsf@luca> <87vas07zdn.fsf@luca> <877f1xu4ra.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494016816 26810 195.159.176.226 (5 May 2017 20:40:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 5 May 2017 20:40:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 05 22:40:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6k1I-0006nT-SL for ged-emacs-devel@m.gmane.org; Fri, 05 May 2017 22:40:08 +0200 Original-Received: from localhost ([::1]:48947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6k1O-0001qx-7y for ged-emacs-devel@m.gmane.org; Fri, 05 May 2017 16:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6k0l-0001py-Kb for emacs-devel@gnu.org; Fri, 05 May 2017 16:39:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6k0g-00013z-RC for emacs-devel@gnu.org; Fri, 05 May 2017 16:39:35 -0400 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:53549) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6k0g-000111-Ho for emacs-devel@gnu.org; Fri, 05 May 2017 16:39:30 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Original-Received: from localhost (ip5f5bdeb7.dynamic.kabel-deutschland.de [95.91.222.183]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id C2178179CAAA; Fri, 5 May 2017 22:39:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1494016753; bh=/qTs2HNUirP5kdkaN5rSWYTauFI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=KjwOsf2Sok++tkFOBlLugbBGQNKmIMzZlzI+GPSEnhJi7j4rzKp9A7DsQzY1ZXZ7w WXwAd6GV1LMVn8gShc5ASuPxEdewk7GI+Dkio/lmQiG7KktK8m6TruOxDqLjGk7tkO fVKDfTMxUju2vcm1IW/OToMPV61piUdScEflis+0= In-Reply-To: (Stefan Monnier's message of "Wed, 03 May 2017 15:40:23 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 143.93.54.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214592 Archived-At: Stefan Monnier writes: > What's missing for it to be "good enough for master" (which AFAIK means > mostly that the code is clean, there are no known bugs, and the > performance is varies between "no worse" and "much better" than what we > currently have)? Don't know about "clean". I found the bug I was mentioning earlier, but it literally took hours. I needed to construct a tree with 7 nodes while performing a series of operations in a very specific manner. It is really difficult to anticipate these kinds of bugs within a test-suite. Benchmarks I've posted in the past: https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00488.html https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00598.html https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00736.html > I don't think we should care too much about those degenerate cases. Yes, we could wait and see if these cases (mostly many overlapping overlays) make a difference in real applications. -ap