From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kevin Brubeck Unhammer Newsgroups: gmane.emacs.bugs Subject: bug#27586: 25.1; sql-interactive-remove-continuation-prompt errors if sql-prompt-regexp is nil (default) Date: Wed, 05 Jul 2017 10:24:00 +0200 Message-ID: <87k23n47hb.fsf@fsfe.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499243119 12093 195.159.176.226 (5 Jul 2017 08:25:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Jul 2017 08:25:19 +0000 (UTC) To: 27586@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 05 10:25:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSfcY-0002s5-Hn for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Jul 2017 10:25:14 +0200 Original-Received: from localhost ([::1]:44804 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSfcd-0000oT-It for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Jul 2017 04:25:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSfcS-0000ke-BW for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:25:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSfcM-0001Wl-7v for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:25:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSfcM-0001Wf-3u for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSfcL-0006Wn-SG for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kevin Brubeck Unhammer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2017 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27586 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.149924305925039 (code B ref -1); Wed, 05 Jul 2017 08:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jul 2017 08:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:52913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSfbf-0006Vn-25 for submit@debbugs.gnu.org; Wed, 05 Jul 2017 04:24:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSfbd-0006VX-1G for submit@debbugs.gnu.org; Wed, 05 Jul 2017 04:24:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSfbW-0001FZ-Gl for submit@debbugs.gnu.org; Wed, 05 Jul 2017 04:24:11 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSfbW-0001FR-DJ for submit@debbugs.gnu.org; Wed, 05 Jul 2017 04:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSfbU-0008SZ-NX for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:24:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSfbR-0001DE-Gd for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:24:08 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35017) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSfbR-0001By-86 for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 04:24:05 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A00D42094F; Wed, 5 Jul 2017 04:24:02 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 05 Jul 2017 04:24:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=2/h9ZurBZALdTl5UZlyHhJ266TatONh+ilbQ4r/SD Ls=; b=fl0DVwYs9Vb0yIOgMJZ5jkCma3rajYgua3mdDG7HxflrUcVbvhaREMhYe +iIzbZCEjGBayLK/I4uPsgPpYVgqXMdwuhh5YFNnhYKBoFzp3qz8N1faudV7vSHV T/6b43r5I0BBeXrnbcx4YzV+TnfVC06e/wrmu93s3dS3kKGz9+TFiVo4Y3AG6IaT UbLYLtxOYlLY0WVtJecxopMSdFHQdyc7vCtpm6uDpdWOUkDhp+vsYVQqxbxQKTd7 1Ro94du+LqfdaRfmuEI5NWkcz6Ft7niR2euGvbpAMDtiJCqnSoXuc3LApYOYPBwC hG+eCLG4OEnc3+NY2yDlWJHRqJvtA== X-ME-Sender: X-Sasl-enc: X70WEIlSWJ7Ke+WlxUXkXw9qRxHljGEz3cce2xZ22pm6 1499243042 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134199 Archived-At: The function sql-interactive-remove-continuation-prompt tries to (string-match sql-prompt-regexp oline) and (string-match sql-prompt-cont-regexp oline) but sql-prompt-regexp and sql-prompt-cont-regexp default to nil. Reproducible from emacs -Q with simply (require 'sql) (sql-interactive-remove-continuation-prompt "") I got the bug when I tried using https://github.com/tumashu/sql-mssql which uses sql.el, and presumably doesn't set these values. Maybe it should, but it seems like sql.el would be more robust if it assumed they could also have their default values :-) Changing (not (or (string-match sql-prompt-regexp oline) (string-match sql-prompt-cont-regexp oline))))) to (not (or (and sql-prompt-regexp (string-match sql-prompt-regexp oline)) (and sql-prompt-cont-regexp (string-match sql-prompt-cont-regexp oline)))))) in sql-interactive-remove-continuation-prompt makes it work as expected for me. In GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-03-29, modified by Debian built on lgw01-37 Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Ubuntu 17.04 Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs25-4TAPj9/emacs25-25.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_MONETARY: nn_NO.UTF-8 value of $LC_NUMERIC: nn_NO.UTF-8 value of $LC_TIME: nn_NO.UTF-8 value of $LANG: nn_NO.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 87257 5017) (symbols 48 20121 0) (miscs 40 49 121) (strings 32 14638 4582) (string-bytes 1 418780) (vectors 16 11914) (vector-slots 8 441003 4990) (floats 8 164 31) (intervals 56 254 0) (buffers 976 18))