bug#27659: 26.0.50; Add string-matched-text: string-match + match-string

[Michael Heerdegen <michael_heerdegen@web.de>]

Philipp Stephani <p.stephani2@gmail.com> writes:

> I think the words `form' and `sexp' are used mostly interchangeably
> nowadays, and the docstring of `rx' speaks of "forms" several times.

If you read carefully, then you'll see that the word "form" is only used
in descriptive language.  The only place where something is named "form"
is the argument of `eval', which actually must be a form.

AFAIC, we use the convention that anything called "a form" is normal
Lisp code to be evaluated, especially if an argument of a macro or
special form is named "FORM".  We describe this convention in the
manual.

If you don't follow it, it will confuse others.  It confused me; I
didn't understand what your `let' does until I had a look at the tests.
This is just not necessary.  Enough people already have problems
understanding and accepting pcase stuff, so I think it's extra important
to use unambiguous language.

And BTW, if we choose to give up that naming convention, shouldn't we
first discuss it?


Michael.