all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: TIMEZONE property for ical export
Date: Sat, 19 Aug 2017 21:25:10 +0200	[thread overview]
Message-ID: <87k21zjr6x.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87a82vv5up.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 19 Aug 2017 10:13:02 -0700")

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

>> BTW, as long as Org doesn't support time zones, the "ox-icalendar"
>> property may be prefixed with "ICALENDAR_" (e.g., ICALENDAR_TZ).
>
> Done!

I realize this is not a great idea since other properties do not have
"ICALENDAR_" prefix. Sorry about that. I suggest to go back to TIMEZONE.

> How does the attached patch look?

> -	     (cat (org-icalendar-get-categories entry info)))
> +	     (cat (org-icalendar-get-categories entry info))
> +	     (tz (org-element-property :ICALENDAR_TZ entry)))

Note that "ICALENDAR_TZ" is not inherited in this case. Neither are
LOCATION and so on, tho. You would need to use
`org-export-get-node-property' in conjunction with
`org-property-inherit-p'.

> -event belongs to.
> +event belongs to. TIMEZONE specifies a time zone for this event
> +only.

Missing space.

Could you add a commit message and an ORG-NEWS entry?

Regards,

  reply	other threads:[~2017-08-19 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 16:53 TIMEZONE property for ical export Eric Abrahamsen
2017-08-19  8:34 ` Nicolas Goaziou
2017-08-19 17:13   ` Eric Abrahamsen
2017-08-19 19:25     ` Nicolas Goaziou [this message]
2017-08-19 19:56       ` Eric Abrahamsen
2017-08-19 21:20         ` Nicolas Goaziou
2017-08-19 21:54           ` Eric Abrahamsen
2017-08-19 22:14             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k21zjr6x.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.