Re: [ELPA] New package: Auto Capitalize Mode

[Ian Dunn <dunni@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

    >> If there are no issues, I'll push it to the git repo myself.
    Stefan> No objection on my side.  Thanks you.  Just one comment:

    >> (defvar-local auto-capitalize-sentence-bounds-function
    >> #'auto-capitalize--default-sentence-bounds "Function to determine
    >> the bounds of the current sentence.
    >> 
    >> Should return the bounds just as `bounds-of-thing-at-point'.")

    Stefan> You only use the `car` part of the return value AFAICT, so
    Stefan> requiring the cdr part just imposes an extra burden.

    Stefan> IOW, I'd remove the `car` you have (twice) in
    Stefan> auto-capitalize--run and put it inside
    Stefan> auto-capitalize--default-sentence-bounds instead (and rename
    Stefan> since it doesn't return "bounds" any more).

    >> (defun turn-on-auto-capitalize-mode () (auto-capitalize-mode 1))

    Stefan> AKA

    Stefan>     (defun turn-on-auto-capitalize-mode ()
    Stefan> (auto-capitalize-mode))

    Stefan> hence, it's unnecessary, you can just do:

    Stefan>     ;;;###autoload (define-globalized-minor-mode
    Stefan> global-auto-capitalize-mode auto-capitalize-mode
    Stefan> auto-capitalize-mode)

I agree on both counts.  I've attached a file with the fixes applied.


[-- Attachment #2: auto-capitalize-mode.el --]
[-- Type: application/emacs-lisp, Size: 4732 bytes --]

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
Ian Dunn