From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Thu, 05 Oct 2017 22:10:52 +0200 Message-ID: <87k209we2b.fsf@mouse.gnus.org> References: <83lglio36q.fsf@gnu.org> <20170924131050.6erv6sshvz23dlbu@odonien.localdomain> <838tgy9d18.fsf@gnu.org> <877ew9vqwv.fsf@mouse.gnus.org> <83vajtx3hu.fsf@gnu.org> <87wp49u9ki.fsf@mouse.gnus.org> <83shexwxce.fsf@gnu.org> <87lgkpu3tl.fsf@mouse.gnus.org> <83poa1wvxi.fsf@gnu.org> <87d161u2g8.fsf@mouse.gnus.org> <20171005200807.ysmclhv5cxuwsnap@odonien.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507234405 21478 195.159.176.226 (5 Oct 2017 20:13:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 20:13:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28402@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 22:13:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0CWD-0004fG-DM for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 22:13:17 +0200 Original-Received: from localhost ([::1]:41889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0CWK-0006dk-TJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 16:13:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0CV4-00065D-Cy for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0CV0-0002Np-Cx for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0CV0-0002NR-9S for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0CV0-00044y-4M for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150723426315604 (code B ref 28402); Thu, 05 Oct 2017 20:12:02 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 5 Oct 2017 20:11:03 +0000 Original-Received: from localhost ([127.0.0.1]:51817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0CU3-00043c-GE for submit@debbugs.gnu.org; Thu, 05 Oct 2017 16:11:03 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:60461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0CU1-000438-PJ for 28402@debbugs.gnu.org; Thu, 05 Oct 2017 16:11:02 -0400 Original-Received: from cm-84.209.243.26.getinternet.no ([84.209.243.26] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e0CTs-0006jQ-UX; Thu, 05 Oct 2017 22:10:54 +0200 In-Reply-To: <20171005200807.ysmclhv5cxuwsnap@odonien.localdomain> (Vasilij Schneidermann's message of "Thu, 5 Oct 2017 22:08:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137986 Archived-At: Vasilij Schneidermann writes: > How deeply nested does typical HTML get anyways? Very. > I recall an exemplary comment from an article on browser rendering > that pointed out that they bail out on degenerate cases, so perhaps > it's better to add that to shr rather than hoping you never hit the > stack limit by following a conservative coding style. shr does check and bail. Search for max-specpdl-size in shr.el. > What I'd additionally do is adding a comment explaining why there's > two very similar snippets of code doing the same thing, otherwise the > next person proposing a patch will change only one of them and be left > head-scratching why it doesn't quite work. Sure; please submit a patch to do so. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no