From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27940: Recursively delete dir34? (yes, no, all, quit) Date: Mon, 16 Oct 2017 14:20:03 +0900 Message-ID: <87k1zv3bzw.fsf@gmail.com> References: <87o9rwxmfz.fsf@jidanni.org> <87r2wrkacy.fsf@calancha-pc> <83a83fybrc.fsf@gnu.org> <87vam365q2.fsf@calancha-pc> <834ltnxzyz.fsf@gnu.org> <871sorz9kg.fsf@calancha-pc> <83tw1nwfhp.fsf@gnu.org> <87r2wppabm.fsf@calancha-pc> <87k22e9obk.fsf@ctlt579.codethink.co.uk> <87shek8pi4.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508131279 32367 195.159.176.226 (16 Oct 2017 05:21:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 05:21:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 27940@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 07:21:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3xpw-0007Cy-Az for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 07:21:12 +0200 Original-Received: from localhost ([::1]:59387 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3xq0-0003ku-E8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 01:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3xpq-0003jt-3V for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3xpm-0004EA-UD for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3xpm-0004E0-Pu for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3xpm-0004Qx-IS for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 01:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 05:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27940-submit@debbugs.gnu.org id=B27940.150813121516973 (code B ref 27940); Mon, 16 Oct 2017 05:21:02 +0000 Original-Received: (at 27940) by debbugs.gnu.org; 16 Oct 2017 05:20:15 +0000 Original-Received: from localhost ([127.0.0.1]:42322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3xp1-0004Pg-LV for submit@debbugs.gnu.org; Mon, 16 Oct 2017 01:20:15 -0400 Original-Received: from mail-pf0-f176.google.com ([209.85.192.176]:54001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3xoz-0004PT-90 for 27940@debbugs.gnu.org; Mon, 16 Oct 2017 01:20:13 -0400 Original-Received: by mail-pf0-f176.google.com with SMTP id t188so12474830pfd.10 for <27940@debbugs.gnu.org>; Sun, 15 Oct 2017 22:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=w01wJTq3/zuUdRhkEWb43F7pUVf/lWt49by7rLt6HI4=; b=dFjtLV5bvuZYyr3+nIO4Dq0uxV8s4NiQPTi7YWEFzVmmZc2gqiHqP+kI5CMfxpXqEG 3nqTJ3uu5btA8KscCSnSr9L1XwTRaUwhhdK65R6lRVcsNPp4L5sD7qvxKA+8AVUnaKnA m6scytV5zKNp9izeq28mDl+5Fom1e4ocdzhjY5PCS1OWTupU6BQQKRAJDsh6DCdZMaJo N0fu7qBSCiK7AyjBV/bbiJf6yFL1CtWm8wmvn6DEc+/F+oy3UwLwcqUeHlNl1QE9P2Yb 8ybJ5xdvs0O7UW18mUyiL9YK2+5hZ2hIL5qlWzOVN0mGeNJo69YExXxOFpv92m5Wql01 F/Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=w01wJTq3/zuUdRhkEWb43F7pUVf/lWt49by7rLt6HI4=; b=JDJ7fDTSXIJsKiVm8sKO4mV2UKTW+laaE8+clR6c19bxR/L4EMGhoka30/c4ZfCgCL 6uqOS+7JMt+Kx66YERJilq7WhnNgoN0jqyO1X+0P4SFOdbDmZWN40lSEVBEr1U+aPWS8 wGC7CRVahl2UsVWmoAemMRgV9G+50unqiVtLD40/B5cbR+2coQFYZ7myBm9t90YSgE4y LuGqlpYJijYokDBskxgGrhP2MVqdG9E/zfQY/JHmcG0lAEiE5gDMAZjkHx+/OEz3DLxs jlshaP+N8KP9+0XbON/+zJ+j/7sn+JTymr7iKPV3dmgu3PkzIivEy9nDsHj2xMrUupAU SKIQ== X-Gm-Message-State: AMCzsaUIt1TSFAF/LK40U7QTQXN1xP9JPscpGosVtEs0m14HDPV/juKl PoogYe8ZVzCaVbZSfgJ012FG5Q== X-Google-Smtp-Source: AOwi7QBuwAa08TSQ5ZWvuzWNE9OrZGE/LOEtADhCpCtfZ3+c6COhIUsr8E396H8CAi8J1rWfQJie8A== X-Received: by 10.98.62.81 with SMTP id l78mr7802615pfa.171.1508131207253; Sun, 15 Oct 2017 22:20:07 -0700 (PDT) Original-Received: from calancha-pc (203.191.218.133.dy.bbexcite.jp. [133.218.191.203]) by smtp.gmail.com with ESMTPSA id a70sm12317991pfa.94.2017.10.15.22.20.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Oct 2017 22:20:06 -0700 (PDT) In-Reply-To: <87shek8pi4.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 15 Oct 2017 10:17:07 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138499 Archived-At: Noam Postavsky writes: > Tino Calancha writes: > >> I believe commit da4438e14f1c55808937872b6d651a807404daa2 >> (dired-delete-file: Dont't ask for empty dirs) >> has fixed it. > > The "no" case of dired-test-bug27940 is failing now. I guess if > RECURSIVE is set to nil, we should not try to delete non-empty > directories, or maybe just catch the error if it happens? Those tests implicitely assume you keep the 'dired-recursive-deletes' default, i.e. 'top; IMO it's not sorprising that they fail if you run them interactively with other 'dired-recursive-deletes' value. We could explicitely set 'dired-recursive-deletes' 'top if you prefer that. The following snippet behaves the same in Emacs-25 and the master branch: emacs -Q /tmp -eval "(customize-set-variable 'dired-recursive-deletes nil)" + foo RET RET + a/b RET + c/d RET + e RET t D yes RET no RET no RET ; Only 'e' is deleted ;; Delete just 'c' U D yes RET ; Signal an error ;; Probably this error should be catched as well? ;; We could open a bug report against 25.3 for this.