From: Tino Calancha <tino.calancha@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 27940@debbugs.gnu.org
Subject: bug#27940: Recursively delete dir34? (yes, no, all, quit)
Date: Mon, 16 Oct 2017 14:20:03 +0900 [thread overview]
Message-ID: <87k1zv3bzw.fsf@gmail.com> (raw)
In-Reply-To: <87shek8pi4.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 15 Oct 2017 10:17:07 -0400")
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> I believe commit da4438e14f1c55808937872b6d651a807404daa2
>> (dired-delete-file: Dont't ask for empty dirs)
>> has fixed it.
>
> The "no" case of dired-test-bug27940 is failing now. I guess if
> RECURSIVE is set to nil, we should not try to delete non-empty
> directories, or maybe just catch the error if it happens?
Those tests implicitely assume you keep the
'dired-recursive-deletes' default, i.e. 'top; IMO it's not
sorprising that they fail if you run them interactively
with other 'dired-recursive-deletes' value.
We could explicitely set 'dired-recursive-deletes' 'top if you
prefer that.
The following snippet behaves the same in Emacs-25 and the master branch:
emacs -Q /tmp -eval "(customize-set-variable 'dired-recursive-deletes nil)"
+ foo RET RET
+ a/b RET
+ c/d RET
+ e RET
t D yes RET no RET no RET ; Only 'e' is deleted
;; Delete just 'c'
U D yes RET ; Signal an error
;; Probably this error should be catched as well?
;; We could open a bug report against 25.3 for this.
next prev parent reply other threads:[~2017-10-16 5:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 23:26 bug#27940: Recursively delete dir34? (yes, no, all, quit) 積丹尼 Dan Jacobson
2017-08-04 8:25 ` Tino Calancha
2017-08-04 8:31 ` Eli Zaretskii
2017-08-04 9:29 ` Tino Calancha
2017-08-04 9:37 ` Tino Calancha
2017-08-04 12:46 ` Eli Zaretskii
2017-08-04 14:33 ` Tino Calancha
2017-08-04 14:54 ` Eli Zaretskii
2017-08-06 4:52 ` Tino Calancha
[not found] ` <87k22e9obk.fsf@ctlt579.codethink.co.uk>
2017-08-09 5:54 ` Tino Calancha
2017-10-15 14:17 ` Noam Postavsky
2017-10-16 5:20 ` Tino Calancha [this message]
2017-10-16 10:36 ` Noam Postavsky
2017-10-16 10:43 ` Tino Calancha
2017-10-17 12:40 ` Noam Postavsky
[not found] ` <<871sorz9kg.fsf@calancha-pc>
[not found] ` <<83tw1nwfhp.fsf@gnu.org>
2017-08-04 15:51 ` Drew Adams
2017-08-04 16:18 ` Tino Calancha
2017-08-04 16:22 ` Drew Adams
2017-08-04 16:34 ` Tino Calancha
[not found] <<87o9rwxmfz.fsf@jidanni.org>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1zv3bzw.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=27940@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.