Re: emacs-26 e1a9dc0: Recognize Org as builtin package (bug#30310)

Re: emacs-26 e1a9dc0: Recognize Org as builtin package (bug#30310)

[Michael Albinus]

rgm@gnu.org (Glenn Morris) writes:

Hi Glenn,

> diff --git a/test/lisp/org/org-tests.el b/test/lisp/org/org-tests.el
> new file mode 100644

Org has defined already several hundreds of ert based tests:

--8<---------------cut here---------------start------------->8---
$ find ~/src/org-mode/testing -name \*.el | xargs grep \(ert-deftest | wc -l
783
--8<---------------cut here---------------end--------------->8---

We shall sync our own tests with them. And I would appreciate to see
those tests also in Emacs' git.

Best regards, Michael.

Re: emacs-26 e1a9dc0: Recognize Org as builtin package (bug#30310)

[Kyle Meyer]

Hi Michael and Glenn,

[Commenting on e1a9dc0 first and then Michael's mail.]

> diff --git a/lisp/org/org.el b/lisp/org/org.el
> index 5272061ccc..4e4620549c 100644
> --- a/lisp/org/org.el
> +++ b/lisp/org/org.el
> @@ -7,6 +7,7 @@
>  ;; Maintainer: Carsten Dominik <carsten at orgmode dot org>
>  ;; Keywords: outlines, hypermedia, calendar, wp
>  ;; Homepage: http://orgmode.org
> +;; Version: 9.1.6

I'll add this to Org's repo.  It isn't appropriate for either of Org's
mainline branches (maint or master) because we don't hardcode the
version anywhere in these branches, but I'll put it on the branch whose
content is synced with the Emacs repo.  (This branch is a superset of
maint and includes various commits that are specifically targeted at the
Emacs repo.)

> diff --git a/test/lisp/org/org-tests.el b/test/lisp/org/org-tests.el
> new file mode 100644

Given that we don't hardcode the version, this new test would fail in
the Org repo's mainline branches.

Michael Albinus <michael.albinus@gmx.de> writes:

> rgm@gnu.org (Glenn Morris) writes:
>
> Hi Glenn,
>
>> diff --git a/test/lisp/org/org-tests.el b/test/lisp/org/org-tests.el
>> new file mode 100644
>
> Org has defined already several hundreds of ert based tests:
>
> $ find ~/src/org-mode/testing -name \*.el | xargs grep \(ert-deftest | wc -l
> 783
>
> We shall sync our own tests with them.

As I noted above, the single test in the new file would fail in the Org
repo.

> And I would appreciate to see those tests also in Emacs' git.

I'd like to see that too.  I think you've requested this before, but I
don't recall where that discussion ended up.  Assuming Rasmus and
Bastien are OK with including the tests, I'll work on making the
necessary changes, with the goal of including the tests once we start
targeting our syncs to Emacs's master rather than the emacs-26 branch.
In addition to including the test files in the sync and making sure
they're working from the Emacs repo, another issue is that many of the
files don't list the FSF as the copyright holder.

-- 
Kyle

Re: emacs-26 e1a9dc0: Recognize Org as builtin package (bug#30310)

[Glenn Morris]

Michael Albinus wrote:

> We shall sync our own tests with them. And I would appreciate to see
> those tests also in Emacs' git.

As I've said before, I think keeping code in two repositories isn't good
practice. I hope the "include elpa packages in the release" idea will
one day be realised.

Re: emacs-26 e1a9dc0: Recognize Org as builtin package (bug#30310)

[John Wiegley]

>>>>> "GM" == Glenn Morris <rgm@gnu.org> writes:

GM> I hope the "include elpa packages in the release" idea will one day be
GM> realised.

Perhaps this can be an objective for 27? I think we have a few packages in
ELPA now that would be nice to include in the distribution for users.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2