bug#30559: 26.0.91; grep-use-null-filename-separator customization

bug#30559: 26.0.91; grep-use-null-filename-separator customization

[Juri Linkov]

This is a request to push the patch to the emacs-26 release branch.

Recipe:
1. ‘M-x customize-variable RET grep-use-null-filename-separator RET’
2. Select a non-default value
3. ‘C-x C-s’

Customizing and saving the new defcustom ‘grep-use-null-filename-separator’
fails because ‘grep-host-defaults-alist’ is missing from the second
‘add-to-list’:

diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index 14e251e..755c9c7 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -734,6 +734,8 @@ grep-compute-defaults
 	     (grep-use-null-device ,grep-use-null-device)
 	     (grep-find-command ,grep-find-command)
 	     (grep-find-template ,grep-find-template)
+	     (grep-use-null-filename-separator
+	      ,grep-use-null-filename-separator)
 	     (grep-find-use-xargs ,grep-find-use-xargs)
 	     (grep-highlight-matches ,grep-highlight-matches))))))
 

bug#30559: 26.0.91; grep-use-null-filename-separator customization

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 20 Feb 2018 23:04:06 +0200
> 
> This is a request to push the patch to the emacs-26 release branch.

OK.

bug#30559: 26.0.91; grep-use-null-filename-separator customization

[Juri Linkov]

>> This is a request to push the patch to the emacs-26 release branch.
>
> OK.

Sorry, I forgot to do the same for zrgrep.  I already noticed earlier
that grep-use-null-filename-separator let-binding is missing here,
but forgot to test this to affirm the necessity to fix zrgrep too.
So this fix is needed for the release branch.

Eli, is it OK to push this patch to emacs-26 as well?

diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index 755c9c7..9b6ebee 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -1184,6 +1184,7 @@ zrgrep
 	   ;; by `grep-compute-defaults'.
 	   (grep-find-template nil)
 	   (grep-find-command nil)
+	   (grep-use-null-filename-separator nil)
 	   (grep-host-defaults-alist nil)
 	   ;; Use for `grep-read-files'
 	   (grep-files-aliases '(("all" . "* .*")

bug#30559: 26.0.91; grep-use-null-filename-separator customization

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: 30559@debbugs.gnu.org
> Date: Fri, 02 Mar 2018 00:45:27 +0200
> 
> Sorry, I forgot to do the same for zrgrep.  I already noticed earlier
> that grep-use-null-filename-separator let-binding is missing here,
> but forgot to test this to affirm the necessity to fix zrgrep too.
> So this fix is needed for the release branch.
> 
> Eli, is it OK to push this patch to emacs-26 as well?
> 
> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
> index 755c9c7..9b6ebee 100644
> --- a/lisp/progmodes/grep.el
> +++ b/lisp/progmodes/grep.el
> @@ -1184,6 +1184,7 @@ zrgrep
>  	   ;; by `grep-compute-defaults'.
>  	   (grep-find-template nil)
>  	   (grep-find-command nil)
> +	   (grep-use-null-filename-separator nil)
>  	   (grep-host-defaults-alist nil)
>  	   ;; Use for `grep-read-files'
>  	   (grep-files-aliases '(("all" . "* .*")

Yes, but please add a comment there explaining why this is done.  (And
AFAIU, our auto-detect stuff needs fixing, if it must be overridden
like that.)

Thanks.