all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Alan Mackenzie <acm@muc.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Let's make C-M-w in isearch yank symbol, not delete character
Date: Mon, 12 Mar 2018 23:19:19 +0200	[thread overview]
Message-ID: <87k1uhqdkw.fsf@mail.linkov.net> (raw)
In-Reply-To: <20180312182458.GA4520@ACM> (Alan Mackenzie's message of "Mon, 12 Mar 2018 18:24:58 +0000")

>> > Why only set those properties in the :setter rather tan just do it at
>> > top-level?  Also, would it be possible to avoid having to list those
>> > commands and instead treat as `isearch-move` any command which uses the
>> > handle-shift-selection?
>
>> Supporting only commands which use the handle-shift-selection
>> makes the most sense.  I tested this to confirm it works as expected:
>
>> diff --git a/lisp/isearch.el b/lisp/isearch.el
>> index 84b121a..245bf8a 100644
>> --- a/lisp/isearch.el
>> +++ b/lisp/isearch.el
>> @@ -2433,8 +2448,8 @@ isearch-pre-command-hook
>>        (setq this-command 'isearch-edit-string))
>>       ;; Don't terminate the search for motion commands.
>>       ((or (and (eq search-exit-option 'move)
>> -               (symbolp this-command)
>> -               (eq (get this-command 'isearch-move) t))
>> +               (stringp (nth 1 (interactive-form this-command)))
>> +               (string-match-p "^^" (nth 1 (interactive-form this-command))))
>>            (and (eq search-exit-option 'shift-move)
>>                 this-command-keys-shift-translated))
>>        (setq this-command-keys-shift-translated nil)
>
> Please don't do this.  handle-shift-selection (whatever that might be)
> is a different feature from the isearch extension, and users should be
> able to customize them independently from each other.  Correction: MUST
> be able to customize them independently.

This solution avoids the flaws of the isearch-allow-scroll feature 
that causes "customization hell" by requiring maintaining a long list of
(put 'command 'isearch-scroll t) minutiae, and requiring adding the same
for every new command.  The feature should be smart enough to deduce
a reasonable default set of supported commands, and adjustable enough
to allow adding/deleting commands to/from the default set.

> Although I haven't been following this thread all that closely, I'm a
> little perturbed that in the space of little over a week, a small
> definite proposal which makes a lot of sense has swollen into a
> significant redesign of isearch, and an incompatible one at that.

The main sub-thread was renamed to the subject "Isearch interaction model"
where we are discussing significant changes such as merging regex and
regular histories into a unified history, integrating find-and-replace
into isearch, keeping toggleable parameters between searches, etc.

> Disclosure: I've had an isearch-yank-symbol bound to C-S-w in my
> isearch-mode-map for several years.

Now isearch-yank-symbol is bound to C-M-w, so you can use the default key.



  reply	other threads:[~2018-03-12 21:19 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 19:10 Let's make C-M-w in isearch yank symbol, not delete character Daniel Colascione
2018-02-23  0:44 ` John Wiegley
2018-02-25 20:55 ` Juri Linkov
2018-02-25 21:12   ` H. Dieter Wilhelm
2018-02-25 21:43   ` Daniel Colascione
2018-03-01 22:39     ` Isearch interaction model (was: Let's make C-M-w in isearch yank symbol, not delete character) Juri Linkov
2018-03-02  0:12       ` Isearch interaction model Daniel Colascione
2018-03-02  0:19         ` Davis Herring
2018-03-02  0:26           ` dancol
2018-03-03 22:50             ` Juri Linkov
2018-03-03 23:46               ` Clément Pit-Claudel
2018-03-04 21:42                 ` Juri Linkov
2018-03-08 22:55                 ` Juri Linkov
2018-03-04 15:39               ` Eli Zaretskii
2018-03-04 17:13                 ` Daniel Colascione
2018-03-04 17:26                   ` Clément Pit-Claudel
2018-03-04 21:58                     ` Juri Linkov
2018-03-04 22:03                     ` Daniel Colascione
2018-03-05  3:33                       ` Eli Zaretskii
2018-03-05 21:33                       ` Juri Linkov
2018-03-04 21:50                   ` Juri Linkov
2018-03-06 21:47           ` Juri Linkov
2018-03-06 22:22             ` dancol
2018-03-07 22:30               ` Juri Linkov
2018-03-07 22:55                 ` dancol
2018-03-08 22:41                   ` Juri Linkov
2018-03-09 11:01                     ` Daniel Colascione
2018-03-10 21:20                       ` Juri Linkov
2018-03-10 21:36                         ` Daniel Colascione
2018-03-11 21:58                           ` Juri Linkov
2018-03-12  3:29                             ` Eli Zaretskii
2018-03-12  8:23                             ` Daniel Colascione
2018-03-12  9:29                               ` Yuri Khan
2018-03-02 16:01       ` Isearch interaction model (was: Let's make C-M-w in isearch yank symbol, not delete character) Richard Stallman
2018-02-26  3:26   ` Let's make C-M-w in isearch yank symbol, not delete character Eli Zaretskii
2018-02-27 21:28     ` Juri Linkov
2018-02-28  3:40       ` Eli Zaretskii
2018-03-01 22:32         ` Juri Linkov
2018-03-02  8:17           ` Eli Zaretskii
2018-03-03 22:34             ` Juri Linkov
2018-03-04 15:47               ` Eli Zaretskii
2018-03-04 21:36                 ` Juri Linkov
2018-03-05  3:31                   ` Eli Zaretskii
2018-03-05 15:59                     ` Eli Zaretskii
2018-03-05 21:25                       ` Juri Linkov
2018-03-06  3:28                         ` Eli Zaretskii
2018-03-06 22:07                           ` Juri Linkov
2018-03-10 11:59                             ` Eli Zaretskii
2018-03-10 18:34                             ` John Shahid
2018-03-10 21:15                               ` Juri Linkov
2018-03-11  2:37                                 ` Stefan Monnier
2018-03-11 21:52                                   ` Juri Linkov
2018-03-12 17:38                                     ` John Shahid
2018-03-12 18:24                                     ` Alan Mackenzie
2018-03-12 21:19                                       ` Juri Linkov [this message]
2018-03-12 21:36                                         ` Juri Linkov
2018-03-11  3:38                                 ` Eli Zaretskii
2018-03-11 14:32                                 ` Herring, Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1uhqdkw.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.