bug#25526: 26.0.50; Gnus sometimes doesn't show article header fully

bug#25526: 26.0.50; Gnus sometimes doesn't show article header fully

[Katsumi Yamaoka]

Hi,

This is a very minor bug, but happens in a certain condition.
Here is a recipe:

・Find an artile that contains a Face image or shows a gravatar
  image.
・Scroll the article window so that the header is shown fully.
・Adjust the frame height so that the article window shows
  a single empty line just beneath the whole header.
・Type `g' to reselect the article.

Then you may see the header is shown not fully.  If not, try
the following in order to adjust the face height so as not to be
integral-multiplication of the default font height:

(setq gnus-face-properties-alist '((png :relief 2)))
(setq gnus-gravatar-properties '(:relief 2))

I was sometimes annoyed with this problem, but I have found
neither a cause of it nor a solution so far.  But this is a
workaround I found today:

(add-hook
 'gnus-article-prepare-hook
 (lambda ()
   (save-selected-window
     (select-window (get-buffer-window gnus-article-buffer))
     (goto-char (point-min)))))

Regards,

bug#25526: 26.0.50; Gnus sometimes doesn't show article header fully

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> I was sometimes annoyed with this problem, but I have found
> neither a cause of it nor a solution so far.  But this is a
> workaround I found today:
>
> (add-hook
>  'gnus-article-prepare-hook
>  (lambda ()
>    (save-selected-window
>      (select-window (get-buffer-window gnus-article-buffer))
>      (goto-char (point-min)))))

Did you try to do the same thing, only just putting it into the Gnus
source code?  :-)  It kinda looks like the right thing to do, but I
don't know anymore what with the hooks and stuff for dedicated windows
and stuff...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#25526: 26.0.50; Gnus sometimes doesn't show article header fully

[Katsumi Yamaoka]

On Thu, 12 Apr 2018 00:34:06 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> I was sometimes annoyed with this problem, but I have found
>> neither a cause of it nor a solution so far.  But this is a
>> workaround I found today:

>> (add-hook
>>  'gnus-article-prepare-hook
>>  (lambda ()
>>    (save-selected-window
>>      (select-window (get-buffer-window gnus-article-buffer))
>>      (goto-char (point-min)))))

Oh, I totally forgot the problem bacause of having set this hook,
but by removing the hook I confirmed it still exists.  Thank you
for following this up.

> Did you try to do the same thing, only just putting it into the Gnus
> source code?  :-)  It kinda looks like the right thing to do, but I
> don't know anymore what with the hooks and stuff for dedicated windows
> and stuff...

I tried this,

--- gnus-art.el~	2018-03-25 21:34:24.056766300 +0000
+++ gnus-art.el	2018-04-12 05:50:51.190490800 +0000
@@ -4699,2 +4699,6 @@
 	    (gnus-configure-windows 'article)
+	    ;; Make sure the article begins with the top of the header.
+	    (save-selected-window
+	      (select-window (get-buffer-window gnus-article-buffer))
+	      (goto-char (point-min)))
 	    (gnus-run-hooks 'gnus-article-prepare-hook)

and verified it does the trick, too.  The point is that to select
the article window while performing (goto-char (point-min)).

Regards,

bug#25526: 26.0.50; Gnus sometimes doesn't show article header fully

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> --- gnus-art.el~	2018-03-25 21:34:24.056766300 +0000
> +++ gnus-art.el	2018-04-12 05:50:51.190490800 +0000
> @@ -4699,2 +4699,6 @@
>  	    (gnus-configure-windows 'article)
> +	    ;; Make sure the article begins with the top of the header.
> +	    (save-selected-window
> +	      (select-window (get-buffer-window gnus-article-buffer))
> +	      (goto-char (point-min)))
>  	    (gnus-run-hooks 'gnus-article-prepare-hook)
>
> and verified it does the trick, too.  The point is that to select
> the article window while performing (goto-char (point-min)).

Looks good to me; please apply to Emacs master.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#25526: 26.0.50; Gnus sometimes doesn't show article header fully

[Katsumi Yamaoka]

On Thu, 12 Apr 2018 13:19:32 +0200, Lars Ingebrigtsen wrote:
> Looks good to me; please apply to Emacs master.  :-)

Thanks.  Done.