From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#31151: 27.0.50; error "Recursive =?UTF-8?Q?=E2=80=98require=E2=80=99?= for feature =?UTF-8?Q?=E2=80=98mm-decode=E2=80=99?=" Date: Sat, 14 Apr 2018 19:26:06 +0900 Message-ID: <87k1tarsn5.fsf@gmail.com> References: <87bmemb7l1.fsf@frege.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523701519 20781 195.159.176.226 (14 Apr 2018 10:25:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2018 10:25:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 31151@debbugs.gnu.org To: Stefan Husmann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 14 12:25:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7IMo-00058Z-T0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 12:25:11 +0200 Original-Received: from localhost ([::1]:51227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7IOu-0000wd-2z for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 06:27:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7IOi-0000w3-4o for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 06:27:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7IOd-0002VE-GF for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 06:27:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7IOd-0002UC-4L for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 06:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f7IOb-0001G9-LA for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 06:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Apr 2018 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31151-submit@debbugs.gnu.org id=B31151.15237016044816 (code B ref 31151); Sat, 14 Apr 2018 10:27:01 +0000 Original-Received: (at 31151) by debbugs.gnu.org; 14 Apr 2018 10:26:44 +0000 Original-Received: from localhost ([127.0.0.1]:51339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7IOJ-0001Fc-PY for submit@debbugs.gnu.org; Sat, 14 Apr 2018 06:26:43 -0400 Original-Received: from mail-pf0-f172.google.com ([209.85.192.172]:32900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7IOI-0001FL-2X for 31151@debbugs.gnu.org; Sat, 14 Apr 2018 06:26:42 -0400 Original-Received: by mail-pf0-f172.google.com with SMTP id f15so7989692pfn.0 for <31151@debbugs.gnu.org>; Sat, 14 Apr 2018 03:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jkl9LiHVY/n7HwWaov5V9b6CQ72YNIbe9ikLCHUgkjI=; b=PIknfNNJgACm0KZ1YXwBMY1eTIB3i+inofLBRjE5yYOTdcJsAAayTe+Mneh8VxRNjw J/5/FmoT57CSorND5okUfkxG0uykAwV5KY+3HtCE8Cpno33th1vi592J9a6z+6X1IUFu JQQdO33PHTZ0mz2+7uAUXBOTLhdSUWcB2yJuZwUbagV5Rumct1G1TDQKXWnet9r5EOuS 33JLE7jce/0DBZj6UT5NVc8y7KcknLoY3GoJfwwYOatXG6GAplJL7Jb6vjdYAvm2vVEH ook7YdPOR3WOxsJRGxOttR5ZDXYnRmV9lKdOpVsa5SFesc/OKbaUdJ7vIbvz58a1LB5c +MtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jkl9LiHVY/n7HwWaov5V9b6CQ72YNIbe9ikLCHUgkjI=; b=q6/3TkBxIDAEQgn5U3brt83RRBg8vbiHfIKO+reAKNP6VZw2dvm4egpVND8vi0P4ta 9qwVNy5yBywZF3wAOtc5m+b/7OHwW3OKPFUK38PumgtJhu6V0cgsZVqONpJPeMUPQBxs oG3ZO8fQ0gVP7vpHowWPvHivp9f047zCJ6XJfZeolNNRNqI4B/yYaWLZFYCfdhTE0g6K GtKABywfTA9dspKHLdf/hAui99I+DUCj8XwrqK44zyuyqCZOt7qkv4NEvvsQI1Ty598F xO7d2sdabkSPH45EIxvCEyq/HhGMzSpFwqVE4Wx/xg2CmMjhcrRsHTtWRp4k4snd9gbr e8ag== X-Gm-Message-State: ALQs6tCsMw07hkR1d3mB0zeUgQB2Zw3pRLTWPeGWARZVadG5kEOsCNua 0l5bFKDBDdliGmhSow2X1LU= X-Google-Smtp-Source: AIpwx48RUN8vRJiOIPLuCKrFqCO7kXJEuWvAjWGauejqBm7mOqUGpo9VRcMAjRoHKfcxJ3amcJWFtg== X-Received: by 10.101.101.196 with SMTP id y4mr6863982pgv.129.1523701595938; Sat, 14 Apr 2018 03:26:35 -0700 (PDT) Original-Received: from calancha-pc (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id m185sm16429523pfc.88.2018.04.14.03.26.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Apr 2018 03:26:34 -0700 (PDT) In-Reply-To: <87bmemb7l1.fsf@frege.i-did-not-set--mail-host-address--so-tickle-me> (Stefan Husmann's message of "Sat, 14 Apr 2018 08:55:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145329 Archived-At: Stefan Husmann writes: > Hello, > > I think the latest change on master on the file broke the build process > for emacs. Thank you very much. It happens after commit 'Don't bind image commands on non-image links in Gnus' (4575ae5a9c5589ac903362486951f0d36c8ff8ee) I think it's OK if we drop the (require 'shr) at the top of the file. --8<-----------------------------cut here---------------start------------->8--- commit ca280c00237653a0898d81387d4d069996b99901 Author: Tino Calancha Date: Sat Apr 14 19:01:03 2018 +0900 Fix circular dependency for mm-decode * lisp/gnus/mm-decode.el: Do not require shr.el at the top of the file; `mm-shr' already requires shr.el in its body, and this function is the only `mm-convert-shr-links' caller (Bug#31151). Declare used variables defined in shr.el, `shr-image-map' and `shr-map'. diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el index 69fc770ec7..18c5837dd5 100644 --- a/lisp/gnus/mm-decode.el +++ b/lisp/gnus/mm-decode.el @@ -25,7 +25,6 @@ (require 'mail-parse) (require 'mm-bodies) -(require 'shr) (eval-when-compile (require 'cl-lib)) (autoload 'gnus-map-function "gnus-util") @@ -1842,6 +1841,8 @@ mm-shr (let ((inhibit-read-only t)) (delete-region min max)))))))) +(defvar shr-image-map) +(defvar shr-map) (autoload 'widget-convert-button "wid-edit") (defvar widget-keymap) --8<-----------------------------cut here---------------end--------------->8---