From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31549: 25.3; bytecompile fails with eval-when-compile Date: Wed, 23 May 2018 18:34:06 -0400 Message-ID: <87k1rugfxd.fsf@gmail.com> References: <8636yknjy1.fsf@gmail.com> <87sh6jgtao.fsf@gmail.com> <83po1mcsty.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527114788 23992 195.159.176.226 (23 May 2018 22:33:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 May 2018 22:33:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: ynyaaa@gmail.com, 31549@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 24 00:33:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLcJZ-00063t-H5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 May 2018 00:33:01 +0200 Original-Received: from localhost ([::1]:35709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLcLg-0003HB-LG for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2018 18:35:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLcLa-0003Fh-9m for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 18:35:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLcLX-0004Md-4D for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 18:35:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37823) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLcLX-0004MH-0n for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 18:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fLcLW-0004WW-Ky for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 18:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 May 2018 22:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31549-submit@debbugs.gnu.org id=B31549.152711485717332 (code B ref 31549); Wed, 23 May 2018 22:35:02 +0000 Original-Received: (at 31549) by debbugs.gnu.org; 23 May 2018 22:34:17 +0000 Original-Received: from localhost ([127.0.0.1]:45720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLcKn-0004VP-IS for submit@debbugs.gnu.org; Wed, 23 May 2018 18:34:17 -0400 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:46185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLcKk-0004V5-Jt; Wed, 23 May 2018 18:34:15 -0400 Original-Received: by mail-io0-f181.google.com with SMTP id f21-v6so24727682iob.13; Wed, 23 May 2018 15:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lgRUMMJScxwc+VXKAQfZ2el7qledU93jDHVkvS0t3Fo=; b=NyPH5V9/nRU/ZJdQx70SKBVi1GgKW8MWL9LRNHKOaZqklF+7TuG8dF+TBdz8i11xol d0ynU+8QyiAgI5panW4C7Y7g8aVEbWjtiQOyn1mQydiWZqaov082rm2WqINAIdnV/Jt/ GziWXN9lZ+9EgajYwN1y/hTiB6PYWslykjnpP/UCQhtM2Hmka+7ujxWJ3GelZAD2zNRY B/DhRn21EwWNiBnkbitWYO7OoKAXIS07k3LERedztAM00xeJeIg69m7JC1UkKgE0ruc7 3yjrskUTLCNEkQ/Ll4upRVojrFYuNMBsup7pepuQJJbsd2h2mFjAN/JHrTs7OV47myzH WMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lgRUMMJScxwc+VXKAQfZ2el7qledU93jDHVkvS0t3Fo=; b=Z0HgvPwAnvyaB9OaEKdh/QCdRGpFh+Lh446jgkN+c13uziVRNOgEF+LzqO94Buc4nE YmaENOgPLwYRuz3Z844JHcQt3XYQcE7B1WySnVNcfq/ng171cLmNpnf8+27QpZzJYc+y Qx3zf0vuC95F4+1zXhsD+lrTWHTCQKgGmFmb2Cas16bMxHsRuYN/V6qea1LkAwF7n984 0g0UkX+TDKBdOjarP0pJ2SKtVTi+OMFhfRV8qe1fAbKCf+dMoGt4YkSifJ7MQhR0u2/L Vi9HEL2cz0wwtEJQwr+U8pDLbBGxRYOaP/rq76wy0eiCShD4labCdv4iulEx+P/S8qOO pnow== X-Gm-Message-State: ALKqPwe1O4W/HqZG0JSAy46EQwr6tZKMZeBl0aORso0vvrldB7WOZxOJ 6DlCrpQ4iIpsOfd+c/t9XH/htA== X-Google-Smtp-Source: AB8JxZrBj9zDN9HSwB+dkiqcNnOq6WiBXZNOb40bGw6zj3Fyi3dPqDt69iIyqxG9GmOBLbh2YrDRJg== X-Received: by 2002:a6b:b447:: with SMTP id d68-v6mr4275366iof.163.1527114848986; Wed, 23 May 2018 15:34:08 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 142-v6sm10909326ion.21.2018.05.23.15.34.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 15:34:08 -0700 (PDT) In-Reply-To: <83po1mcsty.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 May 2018 18:08:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146451 Archived-At: fixed 31549 26.1 quit Eli Zaretskii writes: >> The error is coming from exec_byte_code: >> >> if (MAX_ALLOCA / word_size <= XFASTINT (maxdepth)) >> memory_full (SIZE_MAX); > > You mean, in expansion of SAFE_ALLOCA_LISP_EXTRA? Oh, sorry, I missed that the code has been changed quite a bit in Emacs 26. I said: I can't reproduce in Emacs 26, but only because MAX_ALLOCA is bigger, I think. But v26 exec_byte_code will allocate with malloc if needed, so the bug is fixed (and MAX_ALLOCA is the same size). > How about simply signaling a special error instead of memory_full? > Something like > > error ("Lisp stack overflow"); Still might be worth considering changing the error, although stack overflow doesn't describe it correctly anymore. As far as I can tell, SAFE_ALLOCA_LISP_EXTRA will only signal memory_full if the number of bytes to allocate won't fit in a ptrdiff_t variable. That should be pretty much impossible, barring some strange bugs. So maybe: --- i/src/lisp.h +++ w/src/lisp.h @@ -4662,7 +4662,7 @@ egetenv (const char *var) if (INT_MULTIPLY_WRAPV (nelt, word_size, &alloca_nbytes) \ || INT_ADD_WRAPV (alloca_nbytes, extra, &alloca_nbytes) \ || SIZE_MAX < alloca_nbytes) \ - memory_full (SIZE_MAX); \ + error ("Oversize allocation (0x%lX)", (size_t) alloca_nbytes); \ else if (alloca_nbytes <= sa_avail) \ (buf) = AVAIL_ALLOCA (alloca_nbytes); \ else \