all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: pcase: Semantics of atom QPATS
Date: Wed, 13 Jun 2018 05:41:32 +0200	[thread overview]
Message-ID: <87k1r3qro3.fsf@web.de> (raw)
In-Reply-To: <jwvwov5jurg.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Mon, 11 Jun 2018 10:09:37 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Which is why I prefer signaling an error: it lets us extend the
> semantics of ` without any fear of breaking backward compatibility.

May I add a comment like this to clarify?

 lisp/emacs-lisp/pcase.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
index d3e8899706..32c36ab2cd 100644
--- a/lisp/emacs-lisp/pcase.el
+++ b/lisp/emacs-lisp/pcase.el
@@ -981,6 +981,8 @@ pcase--u1
           (app car ,(list '\` (car qpat)))
           (app cdr ,(list '\` (cdr qpat)))))
    ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat)
+   ;; In all other cases just raise an error so we can't break
+   ;; backward compatibility in the future:
    (t (error "Unknown QPAT: %S" qpat))))
 
 (provide 'pcase)
-- 


Michael.



  parent reply	other threads:[~2018-06-13  3:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10  0:40 pcase: Semantics of atom QPATS Michael Heerdegen
2018-06-11 14:09 ` Stefan Monnier
2018-06-11 14:45   ` Drew Adams
2018-06-11 15:24     ` Stefan Monnier
2018-06-11 20:53   ` Michael Heerdegen
2018-06-13  3:41   ` Michael Heerdegen [this message]
2018-06-13 12:52     ` Stefan Monnier
2018-06-16  4:03       ` Michael Heerdegen
2018-06-16  6:57         ` Eli Zaretskii
2018-06-16  7:32           ` Michael Heerdegen
2018-06-16  7:49             ` Eli Zaretskii
2018-06-17 13:35               ` Michael Heerdegen
2018-06-16 13:42             ` Noam Postavsky
2018-06-16 12:57           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1r3qro3.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.