all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#26411: 25.1.90; [PATCH] Change name of `seqp' argument
@ 2017-04-09  9:20 Simen Heggestøyl
  2018-06-22  0:29 ` Noam Postavsky
  0 siblings, 1 reply; 2+ messages in thread
From: Simen Heggestøyl @ 2017-04-09  9:20 UTC (permalink / raw)
  To: nicolas, 26411

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

The attached patch changes the name of the argument of `seqp' from
`sequence' to `object', which I think makes more sense.

It also matches the name of the arguments of `numberp', `listp',
`sequencep', and so on.

-- Simen



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Change-name-of-seqp-argument.patch --]
[-- Type: text/x-patch, Size: 1594 bytes --]

From abdf2ee994e7e582ca0eb966bfbcb57cec62873e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@gmail.com>
Date: Sun, 9 Apr 2017 11:06:44 +0200
Subject: [PATCH] Change name of `seqp' argument

* lisp/emacs-lisp/seq.el (seqp): Change argument name.

* doc/lispref/sequences.texi: Update the documentation for seqp.
---
 doc/lispref/sequences.texi | 4 ++--
 lisp/emacs-lisp/seq.el     | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/lispref/sequences.texi b/doc/lispref/sequences.texi
index 93e8fa8a5f..c0bedcff19 100644
--- a/doc/lispref/sequences.texi
+++ b/doc/lispref/sequences.texi
@@ -470,8 +470,8 @@ Sequence Functions
 @xref{Definition of length}.
 @end defun
 
-@defun seqp sequence
-  This function returns non-@code{nil} if @var{sequence} is a sequence
+@defun seqp object
+  This function returns non-@code{nil} if @var{object} is a sequence
 (a list or array), or any additional type of sequence defined via
 @file{seq.el} generic functions.
 
diff --git a/lisp/emacs-lisp/seq.el b/lisp/emacs-lisp/seq.el
index 10de248479..c4677ac2f1 100644
--- a/lisp/emacs-lisp/seq.el
+++ b/lisp/emacs-lisp/seq.el
@@ -127,9 +127,9 @@ seq-do-indexed
                (setq index (1+ index)))
              sequence)))
 
-(cl-defgeneric seqp (sequence)
-  "Return non-nil if SEQUENCE is a sequence, nil otherwise."
-  (sequencep sequence))
+(cl-defgeneric seqp (object)
+  "Return non-nil if OBJECT is a sequence, nil otherwise."
+  (sequencep object))
 
 (cl-defgeneric seq-copy (sequence)
   "Return a shallow copy of SEQUENCE."
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#26411: 25.1.90; [PATCH] Change name of `seqp' argument
  2017-04-09  9:20 bug#26411: 25.1.90; [PATCH] Change name of `seqp' argument Simen Heggestøyl
@ 2018-06-22  0:29 ` Noam Postavsky
  0 siblings, 0 replies; 2+ messages in thread
From: Noam Postavsky @ 2018-06-22  0:29 UTC (permalink / raw)
  To: Simen Heggestøyl; +Cc: 26411, nicolas

tags 26411 fixed
close 26411 26.2
quit

> Subject: [PATCH] Change name of `seqp' argument
>
> * lisp/emacs-lisp/seq.el (seqp): Change argument name.
>
> * doc/lispref/sequences.texi: Update the documentation for seqp.

I pushed this to emacs-26.

[1: 3d2e3dc1ca]: 2018-06-21 20:27:35 -0400
  Change name of `seqp' argument (Bug#26411)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3d2e3dc1ca8ee7226668ab5bbd35061d37bcbbec





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-22  0:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-09  9:20 bug#26411: 25.1.90; [PATCH] Change name of `seqp' argument Simen Heggestøyl
2018-06-22  0:29 ` Noam Postavsky

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.