From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) Date: Thu, 12 Jul 2018 17:56:09 +0100 Message-ID: <87k1q0xuja.fsf@gmail.com> References: <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83in5lg4ol.fsf@gnu.org> <83efg9fxnj.fsf@gnu.org> <838t6hfa4h.fsf@gnu.org> <87h8l4lt9q.fsf@gmail.com> <831sc8fttu.fsf@gnu.org> <87a7qwzahe.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1531414493 8308 195.159.176.226 (12 Jul 2018 16:54:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jul 2018 16:54:53 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: tzz@lifelogs.com, Eli Zaretskii , cpitclaudel@gmail.com, larsi@gnus.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 12 18:54:49 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fderg-00021a-KD for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 18:54:48 +0200 Original-Received: from localhost ([::1]:33136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdetm-0001mp-3P for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 12:56:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdet9-0001Wo-P6 for emacs-devel@gnu.org; Thu, 12 Jul 2018 12:56:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdet4-0004ix-Mr for emacs-devel@gnu.org; Thu, 12 Jul 2018 12:56:19 -0400 Original-Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:40361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdet4-0004iY-FV; Thu, 12 Jul 2018 12:56:14 -0400 Original-Received: by mail-wr1-x441.google.com with SMTP id t6-v6so22405689wrn.7; Thu, 12 Jul 2018 09:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Dh1nr811eQWLVInhq1+rdiQ7ySa8WICW2JAo6wMWg+A=; b=tcdKEoGxOe6f4X9YxNvqXSJCq2g39PrCcCzZ/rY5Wo7zXvyZ1LalnXlD/EIOhu1CUY 2yG2PZkqQhR6wpYqfobAeIgMadPgmV6eCxaGuH9Gnfpn7lQeRmsrqEEqnvIM4jPrVdal PPOc0llwWJ0lOX8OmqWYxGaLXDtinJxxljAc6sHkLpVfvxMJrL9qhn0jMBVa9kW4WAE8 cAWXQEfasLT9lopwMO7Pe5VFe2ye5fon9upJ8hbisTTI5d8iAF2gCYIzdVdy/W4CCf/E mwcAnCvpJ7NHPMNcPIGo/RAy8sNBiQgGG1P3rwX4nVqpeeBRJSMtXGKYqjrKeg6ihWQp Zcew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Dh1nr811eQWLVInhq1+rdiQ7ySa8WICW2JAo6wMWg+A=; b=THgmfMoQnli1Xrcw2tG5fCkzUCQy5F7rWE9fDXdnzb8wjFrIkoXTKnHaF8l1cGmdkw ZSsJIAyjneWgGXaE8omE/wrmrRW7NNKQfMEKKsUR/b4PfOH2PiT65NbFfSalC3VeAF8W 8D6luwNYDzp6JAmFRtn09w2ix2Nu2rFPemnpgcxOkgXlKCvY99lL6MA4Vhpgrf04RxQl bn95NoXU8ONt5W9JB34RPQSGAUhefLPQ8d3ZGL6/iwi+oEN7kxiQsclAW9SzUFV+LKWr X21xvu4aLaMGQPX8VlOVzCQUYDZnaiPtnra31FgFFDn7UA/TpBm7424U/eT14fwZVxzq ELdg== X-Gm-Message-State: AOUpUlF8r6M0CeOwbALCIEiQMa4Pt78Qr77aDvNFbonC19CK9hclSWFY xttaZDaVmsrh6BJn/QMxx+Y= X-Google-Smtp-Source: AAOMgpezV5hffqRjbnj9iHYb/odMeI5BCnSEZJwHBmFcu7YlLbvpK2UUiUeeYsltJthEK7sO4waumQ== X-Received: by 2002:adf:d181:: with SMTP id h1-v6mr2338610wri.198.1531414573261; Thu, 12 Jul 2018 09:56:13 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id x7-v6sm5782525wre.94.2018.07.12.09.56.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Jul 2018 09:56:12 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 12 Jul 2018 12:40:18 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227286 Archived-At: Stefan Monnier writes: >> Perhaps it could work in emacs -Q if you make the whole feature depend >> on a variable which I can set dir-locally (presumably not in Emacs, but >> in all my other projects). > > Actually, I think it can be made to work without any customization > (take the absence of a ChangeLog file as the cue). Yes, I'm fine with that. >>> And having the vc-log buffer under change-log-mode is, of course, >>> trivial, either with your customizations or by default. >> But that in turn would lose me some useful that vc-log functionality. >> AFAIU the two modes should be merged, maybe one deriving from the other. > > They're different: > - change-log-mode handles a sequence of commit messages > - it includes dates > - it uses a different syntax for authorship > - its entries are indented with a TAB > - it doesn't know about the special first line "Subject: ". > > So, while I do think that some of change-log-mode's features should be > made available in *vc-log* buffers, it's not just a "merge". Right, we agree. I should have said a "process whereby things from two different things are combined into one thing". >> I think the changes envisioned above (particularly the fileless >> ChangeLog buffer) only justify working on them if noone else is working >> on the better alternative, which is IMO to automatically generate the "* >> file.ext (changed entity)" list from the diff at commit-preparation >> time, as I think someone suggested already. > > AFAIK the two issues are orthogonal/complementary: ChangeLog files are > being phased out pretty much everywhere, AFAIK, so while we'll probably > want change-log-mode to keep supporting them for the foreseeable future, > we do want to adapt it to the newer use case where similar entries are > recorded in the commit log rather than in a file. I have no problem in keeping the ChangeLog funtionality intact. I just said that the small enhancements I proposed to it would probably be useless in the face of an "add-from-diff-directly-into-vc-log" alternative. > BTW, there's diff-add-change-log-entries-other-window (bound to `C-x > 4 A` in diff-mode) which already tries to create the list of entries > from the diff. > [ It turns out it's not as easy as it seems to make it work well :-( ] Thanks, didn't knwo that. Are the current hangups listed somewhere? Jo=C3=A3o