From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Raimon Grau Newsgroups: gmane.emacs.bugs Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el Date: Sat, 11 Aug 2018 12:37:51 +0100 Message-ID: <87k1oxw2uo.fsf@konghq.com> References: <87h8k88l47.fsf@konghq.com> <87effc8kj1.fsf@konghq.com> <8736vsz0mo.fsf@gmail.com> <878t5j9674.fsf@konghq.com> <87mutzxq3k.fsf@gmail.com> <87600m8vn9.fsf@konghq.com> <87600m48pq.fsf@violet.siamics.net> <8736vny1c8.fsf@konghq.com> <87bmab2yu1.fsf@violet.siamics.net> <87zhxvwf1c.fsf@konghq.com> <87sh3nxjvm.fsf@tcd.ie> <87va8i20dj.fsf@violet.siamics.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1533987494 25915 195.159.176.226 (11 Aug 2018 11:38:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Aug 2018 11:38:14 +0000 (UTC) Cc: "Basil L. Contovounesios" , Noam Postavsky To: Ivan Shmakov , 32372@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 11 13:38:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foSDh-0006e8-50 for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Aug 2018 13:38:09 +0200 Original-Received: from localhost ([::1]:59811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foSFm-0001rG-5a for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Aug 2018 07:40:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foSFc-0001h9-2Q for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 07:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foSFX-0000sq-2i for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 07:40:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foSFW-0000se-PE for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 07:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1foSFW-00051u-Cn for bug-gnu-emacs@gnu.org; Sat, 11 Aug 2018 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Raimon Grau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Aug 2018 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32372-submit@debbugs.gnu.org id=B32372.153398758219302 (code B ref 32372); Sat, 11 Aug 2018 11:40:02 +0000 Original-Received: (at 32372) by debbugs.gnu.org; 11 Aug 2018 11:39:42 +0000 Original-Received: from localhost ([127.0.0.1]:47851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foSF9-00051D-FA for submit@debbugs.gnu.org; Sat, 11 Aug 2018 07:39:42 -0400 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:40347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foSF7-000510-9c for 32372@debbugs.gnu.org; Sat, 11 Aug 2018 07:39:37 -0400 Original-Received: by mail-wm0-f49.google.com with SMTP id y9-v6so4328538wma.5 for <32372@debbugs.gnu.org>; Sat, 11 Aug 2018 04:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konghq.com; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=bmXKUrnfNd6aarYM6dyv746GgxKUL2xt5LUsePq07sI=; b=BROt7Lde7CaV9ipjFK5IIn6UAGzTkb9b1UwN4gtjk6WsFrQQ1EUcis+87zqm7p9N/F 2nj65f2aTfTQzBjyROYojW/K5Kx2nN7sT8ces6HM0jO4bZ9ZI4Ws5suNNg5O62aFFXvP W3op9bGaiIKBvdER9R89EuJzmhxoIuhqsElXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=bmXKUrnfNd6aarYM6dyv746GgxKUL2xt5LUsePq07sI=; b=qZvsaq+YGELnYiRlsTZo/oJHYnQKJbV7PudMTVYhZbM4fDQFAk839bAlgRJLSUFMED J0O1z2d6UUP3hBSufswhuAAcjc3iQU32eALAOxQGEk5fmSu6pjEd04Ay2vQ43HQ6AT/i hKixaYNj2WlNByLGgxqyk21MlE+8KA/EAk/4WbZebRLkEwuwlYpihEZRKfgSv7J7Tt3d Yh17LDpR+AZeaRYNO7uBiSUBSN4R4EivePEAfYf5/NfiAY790bp9x8mamwnbsSintxSs PSbcL8YbwJ+t7x1+YK6BWg04jK0cvldJbaNQBblBiLQzPsf0I9bmMOTBSCIH8qvtTQFT zz9w== X-Gm-Message-State: AOUpUlF2f1BzkDFLkp19or0irKfrrvKti0JR2yk3E5EXCRTlSNaxLLca TBtZsA5NWa4tI8YhXdOtrOcE3A== X-Google-Smtp-Source: AA+uWPwJaJJ/dxI3h+y5O/lSgSDV79SO2Yf7JiCAfUOzqJCJsK26mo4R+q3+pIhKsfqrVGBaTCsxSA== X-Received: by 2002:a1c:30d2:: with SMTP id w201-v6mr3510313wmw.47.1533987571648; Sat, 11 Aug 2018 04:39:31 -0700 (PDT) Original-Received: from raikong (55.19.183.185.dyn.akiwifi.com. [185.183.19.55]) by smtp.gmail.com with ESMTPSA id 200-v6sm6742365wmv.6.2018.08.11.04.39.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Aug 2018 04:39:31 -0700 (PDT) X-Google-Original-From: Raimon Grau In-Reply-To: <87va8i20dj.fsf@violet.siamics.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149435 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ivan Shmakov writes: > > What to use here is a mostly a matter of personal style, and a bit of > > a bikeshed at that, so you are likely to get varied opinions. At the > > end of the day it doesn=E2=80=99t really matter what you go with. > > Yes. I ended up using when (and indenting it correctly) if that's ok. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-uuid-as-allowed-thingatpt-symbol.patch >From f7c76007aef325abc31871db108e7e48fe46022c Mon Sep 17 00:00:00 2001 From: Raimon Grau Date: Sun, 5 Aug 2018 22:47:30 +0100 Subject: [PATCH] Add uuid as allowed thingatpt symbol * etc/NEWS: Mention changes in thingatpt.el. * lisp/thingatpt.el (thing-at-point-uuid-regexp): Add regexp for uuid. (top-level): Add 'bounds-of-thing-at-point' operation for 'uuid'. * test/lisp/thingatpt-tests.el: Add tests for uuid at point. --- etc/NEWS | 6 ++++++ lisp/thingatpt.el | 25 ++++++++++++++++++++++--- test/lisp/thingatpt-tests.el | 5 ++++- 3 files changed, 32 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index a1c12a6..57b2586 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -96,6 +96,12 @@ option 'vc-hg-symbolic-revision-styles' to the value '("{rev}")'. --- ** shadowfile.el has been rewritten to support Tramp file names. +--- +** thingatpt.el supports a new "thing" called 'uuid'. + +A symbol 'uuid' can be passed to thing-at-point and it returns the +UUID at point. + * New Modes and Packages in Emacs 26.2 diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 6a978fe..abeb167 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -58,7 +58,7 @@ forward-thing "Move forward to the end of the Nth next THING. THING should be a symbol specifying a type of syntactic entity. Possibilities include `symbol', `list', `sexp', `defun', -`filename', `url', `email', `word', `sentence', `whitespace', +`filename', `url', `email', `uuid', `word', `sentence', `whitespace', `line', and `page'." (let ((forward-op (or (get thing 'forward-op) (intern-soft (format "forward-%s" thing))))) @@ -73,7 +73,7 @@ bounds-of-thing-at-point "Determine the start and end buffer locations for the THING at point. THING should be a symbol specifying a type of syntactic entity. Possibilities include `symbol', `list', `sexp', `defun', -`filename', `url', `email', `word', `sentence', `whitespace', +`filename', `url', `email', `uuid', `word', `sentence', `whitespace', `line', and `page'. See the file `thingatpt.el' for documentation on how to define a @@ -131,7 +131,7 @@ thing-at-point "Return the THING at point. THING should be a symbol specifying a type of syntactic entity. Possibilities include `symbol', `list', `sexp', `defun', -`filename', `url', `email', `word', `sentence', `whitespace', +`filename', `url', `email', `uuid', `word', `sentence', `whitespace', `line', `number', and `page'. When the optional argument NO-PROPERTIES is non-nil, @@ -554,6 +554,25 @@ thing-at-point-email-regexp (put 'buffer 'end-op (lambda () (goto-char (point-max)))) (put 'buffer 'beginning-op (lambda () (goto-char (point-min)))) +;; UUID + +(defconst thing-at-point-uuid-regexp + (rx bow + (repeat 8 hex-digit) "-" + (repeat 4 hex-digit) "-" + (repeat 4 hex-digit) "-" + (repeat 4 hex-digit) "-" + (repeat 12 hex-digit) + eow) + "A regular expression matching a UUID. + +See RFC 4122 for the description of the format.") + +(put 'uuid 'bounds-of-thing-at-point + (lambda () + (when (thing-at-point-looking-at thing-at-point-uuid-regexp 36) + (cons (match-beginning 0) (match-end 0))))) + ;; Aliases (defun word-at-point () diff --git a/test/lisp/thingatpt-tests.el b/test/lisp/thingatpt-tests.el index cfb57de..b4a5fd9 100644 --- a/test/lisp/thingatpt-tests.el +++ b/test/lisp/thingatpt-tests.el @@ -65,7 +65,10 @@ thing-at-point-test-data ("http://example.com/ab)c" 4 url "http://example.com/ab)c") ;; URL markup, lacking schema ("" 1 url "mailto:foo@example.com") - ("" 1 url "ftp://ftp.example.net/abc/")) + ("" 1 url "ftp://ftp.example.net/abc/") + ;; UUID, only hex is allowed + ("01234567-89ab-cdef-ABCD-EF0123456789" 1 uuid "01234567-89ab-cdef-ABCD-EF0123456789") + ("01234567-89ab-cdef-ABCD-EF012345678G" 1 uuid nil)) "List of thing-at-point tests. Each list element should have the form -- 2.7.4 --=-=-=--