From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32604: 26.1.50; memory leak in connect_network_socket Date: Sun, 02 Sep 2018 13:55:46 -0400 Message-ID: <87k1o3rdgd.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1535911165 11546 195.159.176.226 (2 Sep 2018 17:59:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Sep 2018 17:59:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32604@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 02 19:59:21 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwWee-0002qg-9X for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Sep 2018 19:59:20 +0200 Original-Received: from localhost ([::1]:41977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwWgk-0004Oh-IU for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Sep 2018 14:01:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwWbV-0007Q1-H6 for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2018 13:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwWbS-00042n-8z for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2018 13:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38254) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fwWbS-00042a-3t for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2018 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fwWbR-0002Zu-T4 for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2018 13:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Sep 2018 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32604-submit@debbugs.gnu.org id=B32604.15359109569899 (code B ref 32604); Sun, 02 Sep 2018 17:56:01 +0000 Original-Received: (at 32604) by debbugs.gnu.org; 2 Sep 2018 17:55:56 +0000 Original-Received: from localhost ([127.0.0.1]:43272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwWbM-0002Za-Kd for submit@debbugs.gnu.org; Sun, 02 Sep 2018 13:55:56 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:38381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwWbK-0002ZO-Mx for 32604@debbugs.gnu.org; Sun, 02 Sep 2018 13:55:55 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id y3-v6so14231465ioc.5 for <32604@debbugs.gnu.org>; Sun, 02 Sep 2018 10:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=AZgHRn7PskhBWDqG9sv21HEJh8+UpBZtPQ0XU2pKBjY=; b=qvfUfzaYNSiaiFLPswco33lqTp1mQfG7o7xM26Yhpg94JUuhy2gyOwfUEe6NDUqmbE 0l+KJZ3n3bdoknbo5wyEiCqeHqGtDaqZebMCSId2PjEhChYzhTUB8xkbTPbAwYCS+D4s 4QW5g72IIDccBAamkxg7MfsAlYRUUGBIzL5NRem76Yhu6VmKuFKYWF0lV6FVE2eSSCH9 plPA79hK3tdCy7fxBA2iCfOp2XbToYD+gvkUhwau+NPJIdRWeFe6vvi65lV1cOxuHD3Z HpmXSsDkm7FqHEI+FVjA64MbN8NuH8RAJDoLU8NDcfp+65rgp8ywFaP2TeqmG4UZciX7 Dlzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=AZgHRn7PskhBWDqG9sv21HEJh8+UpBZtPQ0XU2pKBjY=; b=IqFJLy5+LHBNFDWo06kxtOMFLB0IylkguHrbVLJvPDqYfJFKSYjywVRI6B5Jt0BZdD XVpDU+I5PWaUqW0ZxFHo0nMDtmQh1+bHDbxsL2n0ocC7+KsDRHTDCPMQyEjXVm6NxaXf GqO/02nF4AjtZEWVwOujZwITIAiaw9YIPmn+DE1TWeuy3tiRlWbgKiycJnHxjlW+9OiN 5/ldKpnX5IccqyLX0BwhGqE68mfbgOalGKV9X21v9x3kxNoJjosZB0uIB9ndjwL45IzK AmNPuCkRQjOuEfxht4Qm37YmXfWQsHzEP/aHEu3NIdOJk+Gb1BaWC2so9acD+Gg4gh2b BW9A== X-Gm-Message-State: APzg51COj5XLQnUKa5azAPrmPKuQlhoLflL1xJDe3ulLEt7M01gfFZIj BM/VbOgs+U78FOi0NyyjJTZtH2Yk X-Google-Smtp-Source: ANB0VdZKWr1gQunV6hNK3iDWSGRT34fS+Tb2RyQ2FU1KEHQUVLMvCdakVOt3BOiSjCDc8Um1iEcrsg== X-Received: by 2002:a6b:fa17:: with SMTP id p23-v6mr12994068ioh.101.1535910948942; Sun, 02 Sep 2018 10:55:48 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i77-v6sm4903025itb.16.2018.09.02.10.55.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Sep 2018 10:55:48 -0700 (PDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Sat, 1 Sep 2018 14:38:51 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149974 Archived-At: YAMAMOTO Mitsuharu writes: > In connect_network_socket (in process.c), the memory pointed to > by the variable `sa=E2=80=99 doesn=E2=80=99t seem to be deallocated. > > 3328 struct sockaddr *sa =3D NULL; > : > 3347 while (!NILP (addrinfos)) > 3348 { > : > 3359 if (sa) > 3360 free (sa); > 3361 sa =3D xmalloc (addrlen); > : > 3533 } > : > > The following patch would fix the leak: > + xfree (sa); I think we would need record_unwind_protect_ptr (xfree, sa); to handle the case where an error is signaled. Similar to how the socket closing is handled: /* Make us close S if quit. */ record_unwind_protect_int (close_file_unwind, s);