From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: delete-selection-mode as default Date: Sun, 09 Sep 2018 19:16:02 +0300 Organization: LINKOV.NET Message-ID: <87k1nvyluh.fsf@mail.linkov.net> References: <83k1nxvm5j.fsf@gnu.org> <877ejxsm18.fsf@toy.adminart.net> <87r2i5308w.fsf@gmail.com> <8336ulv2le.fsf@gnu.org> <87tvmz62q1.fsf@mail.linkov.net> <83pnxnqky3.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536509778 16221 195.159.176.226 (9 Sep 2018 16:16:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2018 16:16:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 09 18:16:14 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fz2Ng-00047a-EM for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 18:16:12 +0200 Original-Received: from localhost ([::1]:47990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz2Pm-0006nQ-W1 for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 12:18:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz2Od-0006Z5-Me for emacs-devel@gnu.org; Sun, 09 Sep 2018 12:17:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fz2Ob-0000vi-Qe for emacs-devel@gnu.org; Sun, 09 Sep 2018 12:17:11 -0400 Original-Received: from pop.dreamhost.com ([64.90.62.162]:39622 helo=pdx1-sub0-mail-a38.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fz2OY-0000sP-U2; Sun, 09 Sep 2018 12:17:07 -0400 Original-Received: from pdx1-sub0-mail-a38.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a38.g.dreamhost.com (Postfix) with ESMTP id 5B9347F24E; Sun, 9 Sep 2018 09:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=gft3TuczRJ7musYSxiuOTbzlwIo=; b= ig6jSABy+Lgv8LHh8hgorOcwNmEv6WS2CnrP6rtKVzE/oorqE3pgy09g7eqX/uyJ ayfgTWuCG8fr53qZ7LO1D3t6DDadWm97uUJd49uD8pwQudPLGUfc2HHklRY/gti0 vmJ6WDO3lNi+tG6KERJEOT/niwp2E+jh5AwN5cq6+hU= Original-Received: from localhost.linkov.net (m91-129-104-147.cust.tele2.ee [91.129.104.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a38.g.dreamhost.com (Postfix) with ESMTPSA id 79CEA7E505; Sun, 9 Sep 2018 09:17:03 -0700 (PDT) In-Reply-To: <83pnxnqky3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Sep 2018 08:49:40 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.90.62.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229567 Archived-At: >> Incidentally, yesterday I discovered a case when Wdired breaks >> delete-selection-mode. Selecting a file name in Wdired and starting >> to type its new name to completely replace an old name with a new one >> signals the error "No file on this line", then removes >> delete-selection-pre-hook from pre-command-hook while leaving >> delete-selection-mode still active, so delete-selection-mode becomes >> completely broken - it doesn't replace the selection anymore. > > In what version of Emacs did you see that? > > We recently fixed bug#32173, and the above sounds like something > similar. Thanks for the reference, I can confirm it's caused by changes in bug#32173 a month ago. I reported a new bug#32673, but maybe it can be merged with the already archived bug#32173. This bug is a clear indication that delete-selection-mode needs to be moved to simple.el where it will fit near shift-select-mode and transient-mark-mode.