From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#32975: Emacs 26.1; GTK Warnings Date: Thu, 11 Oct 2018 11:50:04 +0200 Message-ID: <87k1mo3j8z.fsf@gmail.com> References: <1538936366.8755.2.camel@tjernlund.se> <83zhvpzihx.fsf@gnu.org> <1538976428.8755.6.camel@tjernlund.se> <837eiryx33.fsf@gnu.org> <1539108072.8755.7.camel@tjernlund.se> <83zhvnx9ua.fsf@gnu.org> <1539110025.8755.10.camel@tjernlund.se> <83va6bx7a3.fsf@gnu.org> <87d0si1b41.fsf@gmail.com> <5BBDBC75.2010605@gmx.at> <875zya15cm.fsf@gmail.com> <1539193453.8755.14.camel@tjernlund.se> <871s8x0zgw.fsf@gmail.com> <87tvltylya.fsf@gmail.com> <5BBF08A6.3050604@gmx.at> <87pnwgzxuz.fsf@gmail.com> <5BBF10C4.4080008@gmx.at> <87lg74zvl5.fsf@gmail.com> <5BBF18C8.2040201@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1539251394 23233 195.159.176.226 (11 Oct 2018 09:49:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Oct 2018 09:49:54 +0000 (UTC) Cc: Tjernlund , 32975@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 11 11:49:50 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAXbJ-0005vJ-KE for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2018 11:49:49 +0200 Original-Received: from localhost ([::1]:33235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAXdQ-0008T5-2h for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2018 05:52:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAXcX-0007xA-AR for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 05:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAXcU-0005lT-1f for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 05:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAXcT-0005lG-S4 for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 05:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gAXcT-0001Hz-Ls for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 05:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Oct 2018 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32975-submit@debbugs.gnu.org id=B32975.15392514154902 (code B ref 32975); Thu, 11 Oct 2018 09:51:01 +0000 Original-Received: (at 32975) by debbugs.gnu.org; 11 Oct 2018 09:50:15 +0000 Original-Received: from localhost ([127.0.0.1]:44212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAXbj-0001Gz-48 for submit@debbugs.gnu.org; Thu, 11 Oct 2018 05:50:15 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:50177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAXbg-0001Gn-Vz for 32975@debbugs.gnu.org; Thu, 11 Oct 2018 05:50:13 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id i8-v6so8265146wmg.0 for <32975@debbugs.gnu.org>; Thu, 11 Oct 2018 02:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=oJ2fFOCNEqhi+fj4WVGFUd2lhvlWT7YOU2WIzLsf7j8=; b=Gi9mXdvzRzzWX95PjkkuO2F/4UYtMXD/pdKuMZnqW7tpySH+mBewoUHQ8EYM4Sn1Pf FLrNzwyD7RkPHYsFeLdkfKlB4G/DcVzjQ4ZnHfZKGTs2PH7/mp59HSXGepk2bF2r3mUV nP/xZUvPurEGbmjHVIwFq6sV95itJ6y/s2ugc6Q5SSI0ibhHU8itedOjQHIPEalvbgPV aN3uqAW7PW4siOf9BtNWdaPQ8krAcwkQHXGDGPz0xZs1lcZVM6xmmudHHntdxL5i35SD 9ZEYax8xcm0QQY9iBaOEfLsHo1hdeFZTW8MpMv/PRDcutBDYtaMS4EuhCiIAuB5gcYI7 zpGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=oJ2fFOCNEqhi+fj4WVGFUd2lhvlWT7YOU2WIzLsf7j8=; b=FRU02VEZ5ddZdB1bl8POqFsUYiPAXDwRQk69FB6QGbudaqxlYUemVRtGAX1RjAG/oV PrqLU6n7wRurqPPHcxCPDCHizeljWjX/wQ+Pz4f0Ppx3OCqRW7qaUlBqUIWhJJDw9OEi T3++Zec/CvKGpVS8elRfl2N82OD/1GplrlDbv1O4QxiFU+uloLsmen1bKnFaVO6Oc6jn zCNbVspuo/rZKAcdKxXMrvdfY5X+RT2Vt8q1Ptn3fHMxmOjFI3d+vTwsROXQc0Ua51WH ZJv7KFA3ljgrZO7GKw4LK2hZd7aAMzD0hhbbiwfO+FmCGDKXS/2pgJWyWMmqOXf97FPV 8mZw== X-Gm-Message-State: ABuFfojxAnkttjSNGMJpCaQwQY78fUi6LdxPZG1jGZ6h8Lb6yjHoHZOF zQgRJ0AtJJY2XumkuPorkXD2csoJ X-Google-Smtp-Source: ACcGV604dpd5AeRx/o0EAe/Zz1EAIwAE4N9EqWA/CRRjnAs42WvBF6/orsqWvE2cFgyzMpU4opHWFg== X-Received: by 2002:a1c:4889:: with SMTP id v131-v6mr1040503wma.87.1539251406645; Thu, 11 Oct 2018 02:50:06 -0700 (PDT) Original-Received: from rpluim-ubuntu (cust-west-pareq2-46-193-13-178.wb.wifirst.net. [46.193.13.178]) by smtp.gmail.com with ESMTPSA id g15-v6sm19605284wrr.36.2018.10.11.02.50.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Oct 2018 02:50:05 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <5BBF18C8.2040201@gmx.at> (martin rudalics's message of "Thu, 11 Oct 2018 11:32:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151104 Archived-At: martin rudalics writes: >> We do, but I only see xg_set_widget_bg getting called on scrollbar >> widgets when USE_TOOLKIT_SCROLL_BARS is set, in which case they're GTK >> widgets, so that=CA=BCs the right thing to do. > > I apologize for my stubbornness. > No apology needed > xg_set_background_color (struct frame *f, unsigned long bg) > > has > > xg_set_widget_bg (f, FRAME_GTK_WIDGET (f), FRAME_BACKGROUND_PIXEL (= f)); > > which IIUC does not work on scrollbar widgets. There is only one call to xg_set_background_color, from xfns.c, which looks like this with my patch applied: #ifdef USE_TOOLKIT_SCROLL_BARS # ifdef USE_GTK xg_set_background_color (f, bg); # endif #else So it will only ever happen when the scrollbars are GTK widgets. Robert