From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers Date: Tue, 30 Oct 2018 23:23:29 +0200 Organization: LINKOV.NET Message-ID: <87k1lzruwe.fsf@mail.linkov.net> References: <875zyrrhk8.fsf@mail.linkov.net> <87zhvcteuy.fsf@mail.linkov.net> <5BC83EE4.8030607@gmx.at> <87h8hig9uw.fsf@mail.linkov.net> <5BC98A5F.5050807@gmx.at> <87ftx0nvoi.fsf@mail.linkov.net> <5BCC374E.603@gmx.at> <87a7n7kz7x.fsf@mail.linkov.net> <5BCD935F.8030309@gmx.at> <87in1szirt.fsf@mail.linkov.net> <5BD03F21.6040807@gmx.at> <87lg6map8e.fsf@mail.linkov.net> <5BD15CE0.7080703@gmx.at> <87va5qf1ox.fsf@mail.linkov.net> <5BD2C4AD.3060402@gmx.at> <87r2gbb85y.fsf@mail.linkov.net> <5BD57AB5.2040105@gmx.at> <87woq2xn22.fsf@mail.linkov.net> <5BD6C86F.9030508@gmx.at> <878t2g74oq.fsf@mail.linkov.net> <5BD81DA2.4020003@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540939790 13594 195.159.176.226 (30 Oct 2018 22:49:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 22:49:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32850@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 30 23:49:46 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHcpU-0003PV-6O for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 23:49:44 +0100 Original-Received: from localhost ([::1]:55939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHcra-0005Jc-G5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 18:51:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHcrU-0005JU-1H for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 18:51:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHcrP-0005aI-W5 for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 18:51:47 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHbxb-0002yN-1W for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 17:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gHbxa-0000za-Uu for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 17:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Oct 2018 21:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32850-submit@debbugs.gnu.org id=B32850.15409364043737 (code B ref 32850); Tue, 30 Oct 2018 21:54:02 +0000 Original-Received: (at 32850) by debbugs.gnu.org; 30 Oct 2018 21:53:24 +0000 Original-Received: from localhost ([127.0.0.1]:55971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHbwy-0000yD-6F for submit@debbugs.gnu.org; Tue, 30 Oct 2018 17:53:24 -0400 Original-Received: from glow.birch.relay.mailchannels.net ([23.83.209.71]:31479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHbwt-0000y1-VJ for 32850@debbugs.gnu.org; Tue, 30 Oct 2018 17:53:22 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 819A842AE8; Tue, 30 Oct 2018 21:53:18 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a74.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1783742AFA; Tue, 30 Oct 2018 21:53:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a74.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 30 Oct 2018 21:53:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Invention-Shelf: 2561df156a313d04_1540936398241_3224993933 X-MC-Loop-Signature: 1540936398240:2955467360 X-MC-Ingress-Time: 1540936398240 Original-Received: from pdx1-sub0-mail-a74.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTP id D68DC80ACE; Tue, 30 Oct 2018 14:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Y7blQghwbXMaTCa96sUJ3dFGqt0=; b= ZQgFfRrUcwyX7i/GdEynAOWJaF+o+dIBt0GS3AR8C1aSP5s/xpJSX10CMSWupa8w 3LNujHYgUxnTu03d4/3Ds906hj9oD1PhqXxhv//e1x2QcgB0tZQUIn+6XLv6H62x gxJAu7kqTx6KMMMmpcqLoOXl0CoXqlR+88xFtMaTa6M= Original-Received: from mail.jurta.org (m91-129-101-157.cust.tele2.ee [91.129.101.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a74.g.dreamhost.com (Postfix) with ESMTPSA id 4108F80AD7; Tue, 30 Oct 2018 14:53:15 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a74 In-Reply-To: <5BD81DA2.4020003@gmx.at> (martin rudalics's message of "Tue, 30 Oct 2018 10:00:18 +0100") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedriedtgdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutddurdduheejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtuddrudehjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehruhgurghlihgtshesghhmgidrrghtnecuvehluhhsthgvrhfuihiivgepud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151849 Archived-At: >> (delete-other-windows) (split-window) (delete-window) > > OK. If we document it sufficiently, let's use that. I thought it's ugly. But if there is no other way: diff --git a/lisp/window.el b/lisp/window.el index bcd4fa2959..9fdf005202 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5898,20 +5898,12 @@ window-state-put windows can get as small as `window-safe-min-height' and `window-safe-min-width'." (setq window-state-put-stale-windows nil) - (setq window (window-normalize-window window)) - ;; When WINDOW is internal, reduce it to a live one to put STATE into, - ;; see Bug#16793. + ;; When WINDOW is internal or nil, create a new window. (unless (window-live-p window) - (let ((root window)) - (setq window (catch 'live - (walk-window-subtree - (lambda (window) - (when (and (window-live-p window) - (not (window-parameter window 'window-side))) - (throw 'live window))) - root))) - (delete-other-windows-internal window root))) + (delete-other-windows) + (setq window (split-window)) + (delete-window)) (set-window-dedicated-p window nil)