From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: van@scratch.space, 33398@debbugs.gnu.org
Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion
Date: Sun, 25 Nov 2018 22:25:25 +0200 [thread overview]
Message-ID: <87k1l0c3be.fsf@mail.linkov.net> (raw)
In-Reply-To: <837eh1jeak.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Nov 2018 18:46:27 +0200")
>> >> (defface hi-pink
>> >> - '((((background dark)) (:background "pink" :foreground "black"))
>> >> - (t (:background "pink")))
>> >> + '((((min-colors 88) (background dark))
>> >> + (:background "pink" :foreground "black"))
>> >> + (((background dark)) (:background "red" :foreground "black"))
>> >> + (((min-colors 88)) (:background "pink"))
>> >> + (t (:background "red")))
>> >> "Face for hi-lock mode."
>> >> :group 'hi-lock-faces)
>> >
>> > Thanks for working on this, but unfortunately changing the default
>> > colors for Emacs faces is not that easy (which is why we do that only
>> > very rarely).
>>
>> I understand that face changing is very sensitive area, so I don't insist
>> on these changes if the result is worse. What I was trying to do is to
>> add 2 more default colors: the current 4 is too small number of the default
>> background colors, so adding 2 colors will at least cover all available
>> 6 non-black-white colors on a 8-color TTY.
>
> Then I don't understand why you also changed the faces we had
> already. Leaving them alone will lower the risk that someone will
> become annoyed by the changes.
The problem is that the condition '(t (:background "pink"))' is
automatically translated to "magenta" on a 8-color TTY. And in the
'hi-blue' face '(t (:background "light blue"))' is translated to "cyan".
So to add a new face with a "blue" background on a 8-color TTY
with the condition '(t (:background "blue"))' we have no suitable name
for a new face, become the most suitable name 'hi-blue' is already
taken by the existing face that is displayed as "cyan".
The same problem is with 'hi-pink' that is currently translated to
"magenta", not to "red" on a 8-color TTY.
>> emacs -Q -nw --color=8 -f list-colors-display
>>
>> displays a list of 8 colors, good. But running
>>
>> emacs -Q -nw --color=16 -f list-colors-display
>>
>> displays a list of 256 colors, the same number of colors properly displayed by
>>
>> emacs -Q -nw --color=256 -f list-colors-display
>>
>> Is this a bug in Emacs?
>
> Not a bug, a subtlety: the only numeric argument you can reliably
> submit to --color= is 8, because it alone has a standard set of
> termcap/terminfo commands to set and reset colors. Maybe we should
> amend the documentation so that people don't expect other numbers to
> work.
Currently it's documented in (info "(emacs) Colors X")
‘--color=MODE’
...
‘NUM’
...
Depending on your terminal’s capabilities, Emacs might be able
to turn on a color mode for 8, 16, 88, or 256 as the value of NUM.
I guess the key point is "Depending on your terminal’s capabilities".
This might explain why values other than 8 and 256 are not supported.
next prev parent reply other threads:[~2018-11-25 20:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:58 bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Van L
2018-11-15 21:25 ` Juri Linkov
2018-11-15 22:13 ` Van L
2018-11-17 20:54 ` Juri Linkov
2018-11-19 3:10 ` Van L
2018-11-19 21:58 ` Juri Linkov
2018-11-20 4:00 ` Van L
2018-11-20 22:59 ` Juri Linkov
2018-11-21 12:23 ` Van L
2018-11-21 22:56 ` Juri Linkov
2018-11-22 0:32 ` Van L
2018-11-22 22:16 ` Juri Linkov
2018-11-23 0:56 ` Van L
2018-11-23 8:38 ` Eli Zaretskii
2018-11-23 11:22 ` Van L
2018-11-23 15:54 ` Eli Zaretskii
2018-11-23 8:35 ` Eli Zaretskii
2018-11-24 21:29 ` Juri Linkov
2018-11-25 16:46 ` Eli Zaretskii
2018-11-25 20:25 ` Juri Linkov [this message]
2018-11-26 16:01 ` Eli Zaretskii
2018-11-26 23:27 ` Juri Linkov
2018-11-27 5:56 ` Eli Zaretskii
2018-11-27 23:49 ` Juri Linkov
2018-11-28 23:06 ` Juri Linkov
2018-11-29 7:32 ` Eli Zaretskii
2018-11-29 22:29 ` Juri Linkov
2018-11-30 7:16 ` Eli Zaretskii
2018-12-19 0:36 ` Juri Linkov
2018-12-19 3:50 ` Van L
2018-12-19 21:37 ` Juri Linkov
2018-12-19 15:19 ` Eli Zaretskii
2018-12-19 21:40 ` Juri Linkov
2018-12-20 0:16 ` Van L
2018-12-20 16:11 ` Eli Zaretskii
2018-12-20 23:01 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1l0c3be.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33398@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=van@scratch.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.