all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: Keeping replace-buffer-contents runtime in bounds
Date: Mon, 25 Feb 2019 07:28:17 +0100	[thread overview]
Message-ID: <87k1hoidq6.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkS2vt6Amf80KkQxZ7VevwYyWEqqwevj+hz_1qd1BUmJfg@mail.gmail.com> (Philipp Stephani's message of "Sun, 24 Feb 2019 21:13:03 +0100")

Philipp Stephani <p.stephani2@gmail.com> writes:

Hi Philipp & Eli,

>> > The gotcha about aborting after more than the time-out value should
>> > be mentioned in the doc string.
>> >
>> > Thanks for working on this.  My only other comment is that maybe we
>> > should allow passing the time-out value via the function's
>> > arguments, not via a global variable.  It seems to me the time-out
>> > will be used in more use cases than MAX-COSTS, and in any case
>> > treating these two differently API-wise sounds strangely
>> > inconsistent.
>>
>> I've done that and landed it in master.
>
> Thanks. However, the variable replace-buffer-contents-max-secs is
> still present, did you maybe keep it by mistake?

Of course, yes.  Feel free to delete it.  Otherwise I'll do it when I'm
back home this evening.

And thank you both for fixing my typo in text.texi.  However, now we use
"@deffn Command" for replace-region-contents but it is no command.
Maybe it should be one with interactive spec "a"?  But how likely is it
that the replacement function is already an available named function?

     Tassilo



  reply	other threads:[~2019-02-25  6:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 20:09 Keeping replace-buffer-contents runtime in bounds Tassilo Horn
2019-02-17 15:50 ` Eli Zaretskii
2019-02-17 18:26   ` Tassilo Horn
2019-02-17 18:59     ` Eli Zaretskii
2019-02-24 10:11   ` Tassilo Horn
2019-02-24 16:12     ` Eli Zaretskii
2019-02-24 20:13     ` Philipp Stephani
2019-02-25  6:28       ` Tassilo Horn [this message]
2019-02-25 20:16         ` Tassilo Horn
2019-02-25 21:03           ` Stefan Monnier
2019-02-26  6:51             ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1hoidq6.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.